OCPBUGS-XXX: Do not use /tmp as a source directory for the image

[elfosardo]

Unfortunately, a lot of code in Ironic ignores the tempdir configuration. Even worse, the default value for this option relies on having a writable /tmp, which makes the current approach not functional without mounting an emptyDir to /tmp. But if an emptyDir is mounted to /tmp, we lose access to all the template files stored there.

This change uses a new directory /templates as a source for files that needs copying/templating in runtime.

Also fix usage of /var/tmp in httpd.conf.

Document the requirements.

(cherry picked from commit 8f8b12b)

[openshift-ci-robot]

@elfosardo: This pull request references Jira Issue OCPBUGS-67275, which is invalid:

• expected the bug to target either version "4.20." or "openshift-4.20.", but it targets "4.21" instead
• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-67275 to depend on a bug targeting a version in 4.21.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Unfortunately, a lot of code in Ironic ignores the tempdir configuration. Even worse, the default value for this option relies on having a writable /tmp, which makes the current approach not functional without mounting an emptyDir to /tmp. But if an emptyDir is mounted to /tmp, we lose access to all the template files stored there.

This change uses a new directory /templates as a source for files that needs copying/templating in runtime.

Also fix usage of /var/tmp in httpd.conf.

Document the requirements.

(cherry picked from commit 8f8b12b)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[elfosardo]

/jira refresh

[openshift-ci-robot]

@elfosardo: This pull request references Jira Issue OCPBUGS-67275, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-67275 to depend on a bug targeting a version in 4.21.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[elfosardo]

/jira refresh

[openshift-ci-robot]

@elfosardo: This pull request references Jira Issue OCPBUGS-67275, which is invalid:

• expected Jira Issue OCPBUGS-67275 to depend on a bug targeting a version in 4.21.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[elfosardo]

/jira refresh

[openshift-ci-robot]

@elfosardo: This pull request references Jira Issue OCPBUGS-67275, which is invalid:

• expected the bug to be open, but it isn't
• expected the bug to target either version "4.20." or "openshift-4.20.", but it targets "4.21" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Obsolete) instead
• expected dependent Jira Issue OCPBUGS-67294 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead
• expected dependent Jira Issue OCPBUGS-67294 to target a version in 4.21.0, but it targets "4.20.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[elfosardo]

/jira refresh

[openshift-ci-robot]

@elfosardo: This pull request references Jira Issue OCPBUGS-67275, which is invalid:

• expected dependent Jira Issue OCPBUGS-67294 to target a version in 4.21.0, but it targets "4.21" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[elfosardo]

/jira refresh

[openshift-ci-robot]

@elfosardo: This pull request references Jira Issue OCPBUGS-67275, which is valid.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.z) matches configured target version for branch (4.20.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-67294 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-67294 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
• bug has dependents

Requesting review from QA contact:
/cc @jadhaj

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[elfosardo]

/cc @dtantsur

[mabulgu]

LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, mabulgu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [elfosardo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[iurygregory]

/lgtm

[dtantsur]

/retitle OCPBUGS-XXX: Do not use /tmp as a source directory for the image

@elfosardo this change has nothing to do with the bug in question or really anything downstream, so please attach it to some other card.

[openshift-ci-robot]

@elfosardo: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

Unfortunately, a lot of code in Ironic ignores the tempdir configuration. Even worse, the default value for this option relies on having a writable /tmp, which makes the current approach not functional without mounting an emptyDir to /tmp. But if an emptyDir is mounted to /tmp, we lose access to all the template files stored there.

This change uses a new directory /templates as a source for files that needs copying/templating in runtime.

Also fix usage of /var/tmp in httpd.conf.

Document the requirements.

(cherry picked from commit 8f8b12b)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[elfosardo]

/hold

[openshift-ci]

@elfosardo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.