Skip to content

Add Node Feature Discovery Operator collection script#508

Open
mmayeras wants to merge 2 commits intoopenshift:mainfrom
mmayeras:main
Open

Add Node Feature Discovery Operator collection script#508
mmayeras wants to merge 2 commits intoopenshift:mainfrom
mmayeras:main

Conversation

@mmayeras
Copy link

No description provided.

Mickael Mayeras added 2 commits October 23, 2025 12:19
- Add gather_nfd script to collect NFD operator data
- Include namespace inspection and CRD collection for:
  - nodefeaturediscoveries
  - nodefeaturegroups
  - nodefeaturerules
  - nodefeatures
- Integrate gather_nfd into main gather script
- Follow same pattern as gather_nmstate script
- Add namespace parameter (-n) to CRD collection commands
- Fix operator name to use full 'node-feature-discovery-operator' name
- Uncomment namespace inspection
- Add debug logging to show which CRDs are being collected
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 23, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2025

Hi @mmayeras. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yevgeny-shnaidman
Copy link

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 18, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2025

@mmayeras: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@yevgeny-shnaidman
Copy link

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmayeras, yevgeny-shnaidman
Once this PR has been reviewed and has the lgtm label, please assign sferich888 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yevgeny-shnaidman
Copy link

/assign @sferich888

@yevgeny-shnaidman
Copy link

@ingvagabund @sferich888 can we get the review for this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants