Skip to content

Conversation

@nidangavali
Copy link

@nidangavali nidangavali commented Jan 3, 2026

Description

Add a /pr-tests claude command to generate QE-focused test cases and testing approaches based on the respective PR.

Github / Jira issue: CLID-515

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code Improvements (Refactoring, Performance, CI upgrades, etc)
  • Internal repo assets (diagrams / docs on github repo)
  • This change requires a documentation update on openshift docs

How Has This Been Tested?

Run /pr-tests pr-url when using claude.

Expected Outcome

  • Comprehensive QE test scenario descriptions (integration, E2E, regression, manual)
  • Changed line numbers for precise change tracking (no code output)
  • Priority-ranked test scenarios (critical, high, medium priority)
  • Analysis of what changed, impact assessment, and risk evaluation
  • Edge cases and error conditions to verify
  • Test environment and configuration requirements

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 3, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 3, 2026

@nidangavali: This pull request references CLID-515 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Description

Add a /pr-tests claude command to generate QE-focused test cases and testing approaches based on the respective PR.

Github / Jira issue:

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code Improvements (Refactoring, Performance, CI upgrades, etc)
  • Internal repo assets (diagrams / docs on github repo)
  • This change requires a documentation update on openshift docs

How Has This Been Tested?

Run /pr-tests pr-url when using claude.

Expected Outcome

  • Comprehensive QE test scenario descriptions (integration, E2E, regression, manual)
  • Changed line numbers for precise change tracking (no code output)
  • Priority-ranked test scenarios (critical, high, medium priority)
  • Analysis of what changed, impact assessment, and risk evaluation
  • Edge cases and error conditions to verify
  • Test environment and configuration requirements

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from adolfo-ab and aguidirh January 3, 2026 02:37
@openshift-ci
Copy link

openshift-ci bot commented Jan 3, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nidangavali
Once this PR has been reviewed and has the lgtm label, please assign r4f4 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nidangavali
Copy link
Author

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 3, 2026

@nidangavali: This pull request references CLID-515 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Description

Add a /pr-tests claude command to generate QE-focused test cases and testing approaches based on the respective PR.

Github / Jira issue: CLID-515

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code Improvements (Refactoring, Performance, CI upgrades, etc)
  • Internal repo assets (diagrams / docs on github repo)
  • This change requires a documentation update on openshift docs

How Has This Been Tested?

Run /pr-tests pr-url when using claude.

Expected Outcome

  • Comprehensive QE test scenario descriptions (integration, E2E, regression, manual)
  • Changed line numbers for precise change tracking (no code output)
  • Priority-ranked test scenarios (critical, high, medium priority)
  • Analysis of what changed, impact assessment, and risk evaluation
  • Edge cases and error conditions to verify
  • Test environment and configuration requirements

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Jan 3, 2026

@nidangavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-images 6d37f82 link true /test okd-scos-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@adolfo-ab adolfo-ab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should avoid talking about "QE testing", since we are trying to bridge the gap between dev and QE, and instead talk only about testing from a unified point of view

@nidangavali
Copy link
Author

I think we should avoid talking about "QE testing", since we are trying to bridge the gap between dev and QE, and instead talk only about testing from a unified point of view

Agreed but the reason I added QE-focus was because of the areas the slash command will mostly cover. I tried to avoid unit tests majorly for 2 reasons:

  1. I feel the unit test should be more precisely focused on the code because of which there should be a separate slash command for unit test.
    2.The output given by the current slash command is very detailed and long. Adding output for unit test which will also involve multiple code snippets of tests in case there are multiple changes in the PR.
    This slash command mainly focuses on giving the testing approach and not the code for automation or any code changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants