-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fix typo mistake: appliction 2 application. #11308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo mistake: appliction 2 application. #11308
Conversation
|
Hi @jmferrer. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Can one of the admins verify this patch?
|
vrutkovs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmferrer, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jmferrer do you know if this change has been made in the upstream source for this content? If we were to sync it again from them i'm afraid it would regress. See roles/openshift_examples/examples-sync.sh |
|
@sdodson : you are right. I suggested changes here: jboss-openshift/application-templates#497 |
|
Awesome thanks for chasing that down. I wasn't sure exactly which upstream repo the content you modified came from. |
NOTICE
Master branch is closed! A major refactor is ongoing in devel-40.
Changes for 3.x should be made directly to the latest release branch they're
relevant to and backported from there.