-
Notifications
You must be signed in to change notification settings - Fork 1.9k
OSDOCS-17769: m7 AWS instance type #104658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@skopacz1: This pull request references OSDOCS-17769 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.22." or "openshift-4.22.", but it targets "openshift-4.21" instead. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.ShortDescription: Assign [role="_abstract"] to a paragraph to use it as in DITA.
|
@skopacz1: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@skopacz1: This pull request references OSDOCS-17769 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.22." or "openshift-4.22.", but it targets "openshift-4.21" instead. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| * `i3.*` | ||
| * `m4.*` | ||
| * `m5.*` | ||
| * `m7.*` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find the docs for a secret region, so perhaps this was unnecessary to add
|
@skopacz1 IIRC, the instance types are stored in https://github.com/openshift/installer/blob/main/docs/user/aws/tested_instance_types_x86_64.md and they are for commercial regions only, LocalZone, WavelengthZone and Secret regions are not included. |
|
@yunjiang29 thanks for clarifying. In that case, since the only affected file is maintained outside of this docs repo, I will close this PR. Will you be making the update to the file you linked? I see that you added the m6 instance type a few years ago. Let me know if you need any help, though I am not as familiar with the installer repo |
|
in favor of openshift/installer#10246 |
OSDOCS-17769
Version(s): 4.21+
This PR adds m7 as a supported instance type for AWS machines
QE review:
Previews: