Skip to content

OCPBUGS-60006: Updating CRs to match telco-reference eng repo changes #97766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OCPBUGS-60006: Updating CRs to match telco-reference eng repo changes #97766

wants to merge 1 commit into from

Conversation

rohennes
Copy link
Contributor

@rohennes rohennes commented Aug 19, 2025 •
edited
Loading

OCPBUGS-60006: Updating CRs to match telco-reference eng repo changes

Version(s):
4.19+

Issue:
https://issues.redhat.com/browse/OCPBUGS-60006

Link to docs preview:
https://97766--ocpdocs-pr.netlify.app/openshift-enterprise/latest/scalability_and_performance/telco-hub-rds.html#telco-yaml-reference_telco-hub

QE review:

  • QE has approved this change.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 19, 2025
@openshift-ci-robot
Copy link

@rohennes: This pull request references Jira Issue OCPBUGS-60006, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

OCPBUGS-60006: Updating CRs to match telco-reference eng repo changes

Version(s):
4.19+

Issue:

Link to docs preview:
https://issues.redhat.com/browse/OCPBUGS-60006

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 19, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Aug 19, 2025 •
edited
Loading

🤖 Mon Aug 25 13:55:13 - Prow CI generated the docs preview:

https://97766--ocpdocs-pr.netlify.app/openshift-enterprise/latest/scalability_and_performance/telco-hub-rds.html

jgato
jgato reviewed Aug 20, 2025
View reviewed changes
scalability_and_performance/telco-hub-rds.adoc
@@ -367,6 +374,13 @@ include::https://raw.githubusercontent.com/openshift-kni/telco-reference/release
include::https://raw.githubusercontent.com/openshift-kni/telco-reference/release-4.19/telco-hub/configuration/reference-crs/optional/odf-internal/odfOperatorGroup.yaml[]
----

[id="telco-hub-odfReady-yaml_{context}"]
.odfReady.yaml
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imiller0 should we also include references to this? it is just a policy to sync on ArgoCD deployment.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is part of the reference, yes we should include it here. As you note it isn't required configuration but is required for reliable rollout of the config using argocd.

imiller0
imiller0 reviewed Aug 21, 2025
View reviewed changes
Copy link

@imiller0 imiller0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are still missing
required/acm/pull-secret-copy.yaml
required/gitops/argocd-application.yaml

There are a couple of kustomization.yaml files which I don't think should be included

scalability_and_performance/telco-hub-rds.adoc
@@ -367,6 +374,13 @@ include::https://raw.githubusercontent.com/openshift-kni/telco-reference/release
include::https://raw.githubusercontent.com/openshift-kni/telco-reference/release-4.19/telco-hub/configuration/reference-crs/optional/odf-internal/odfOperatorGroup.yaml[]
----

[id="telco-hub-odfReady-yaml_{context}"]
.odfReady.yaml
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is part of the reference, yes we should include it here. As you note it isn't required configuration but is required for reliable rollout of the config using argocd.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 25, 2025

@rohennes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@jgato jgato jgato left review comments

@imiller0 imiller0 imiller0 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rohennes @openshift-ci-robot @ocpdocs-previewbot @jgato @imiller0