-
Notifications
You must be signed in to change notification settings - Fork 1.8k
ROX-11689: Add info about key value pairs and roles #97791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-11689: Add info about key value pairs and roles #97791
Conversation
@kcarmichael08: This pull request references ROX-11689 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Fri Sep 05 13:08:33 - Prow CI generated the docs preview: |
a6e80df
to
972b7c5
Compare
@kcarmichael08: This pull request references ROX-11689 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
. For *Key*, select one of the values from `userid`, `name`, `email` or `group`. | ||
. For *Value*, enter the value of the user ID, name, email address or group based on the key you selected. | ||
. Click the *Role* drop-down menu and select the role you want to assign. | ||
. For *Key*, select one of the values from `userid`, `name`, `email`, `groups`, or `roles`. For example, to assign the `Analyst` role to a user by email, first select `email`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where do roles
come from? I don't see them in the list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, that's so weird - I know that I edited it because I saw a "role" choice, but checking on the demo site now, I don't see one. Maybe it was a weird thing that someone was testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be that.
. For *Key*, select one of the values from `userid`, `name`, `email` or `group`. | ||
. For *Value*, enter the value of the user ID, name, email address or group based on the key you selected. | ||
. Click the *Role* drop-down menu and select the role you want to assign. | ||
. For *Key*, select one of the values from `userid`, `name`, `email`, `groups`, or `roles`. For example, to assign the `Analyst` role to a user by email, first select `email`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"first select email." — doesn't seem like a complete instruction, which is only continued in the next item example. Is it helpful here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
652540a
to
6ad0252
Compare
@kcarmichael08: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@kcarmichael08: This pull request references ROX-11689 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is perfect. Well done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. I have no inputs. Ship It!
/cherrypick rhacs-docs-4.6 |
@kcarmichael08: new pull request created: #98661 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@kcarmichael08: new pull request created: #98662 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@kcarmichael08: new pull request created: #98663 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@kcarmichael08: new pull request created: #98664 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
4.6+
Issue
Link to docs preview
QE review: ACS has no QE, approved by SME
Additional information: