Skip to content

Conversation

kcarmichael08
Copy link
Contributor

@kcarmichael08 kcarmichael08 commented Aug 19, 2025

Version(s):
4.6+

Issue

Link to docs preview

QE review: ACS has no QE, approved by SME

  • QE has approved this change.

Additional information:

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 19, 2025

@kcarmichael08: This pull request references ROX-11689 which is a valid jira issue.

In response to this:

Version(s):
4.6+

Issue

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 19, 2025
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 19, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Aug 19, 2025

@kcarmichael08 kcarmichael08 force-pushed the ROX-11689-roles branch 2 times, most recently from a6e80df to 972b7c5 Compare August 20, 2025 15:51
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 3, 2025

@kcarmichael08: This pull request references ROX-11689 which is a valid jira issue.

In response to this:

Version(s):
4.6+

Issue

Link to docs preview

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

. For *Key*, select one of the values from `userid`, `name`, `email` or `group`.
. For *Value*, enter the value of the user ID, name, email address or group based on the key you selected.
. Click the *Role* drop-down menu and select the role you want to assign.
. For *Key*, select one of the values from `userid`, `name`, `email`, `groups`, or `roles`. For example, to assign the `Analyst` role to a user by email, first select `email`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do roles come from? I don't see them in the list.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's so weird - I know that I edited it because I saw a "role" choice, but checking on the demo site now, I don't see one. Maybe it was a weird thing that someone was testing?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be that.

. For *Key*, select one of the values from `userid`, `name`, `email` or `group`.
. For *Value*, enter the value of the user ID, name, email address or group based on the key you selected.
. Click the *Role* drop-down menu and select the role you want to assign.
. For *Key*, select one of the values from `userid`, `name`, `email`, `groups`, or `roles`. For example, to assign the `Analyst` role to a user by email, first select `email`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"first select email." — doesn't seem like a complete instruction, which is only continued in the next item example. Is it helpful here?

Copy link

@parametalol parametalol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

openshift-ci bot commented Sep 5, 2025

@kcarmichael08: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 5, 2025

@kcarmichael08: This pull request references ROX-11689 which is a valid jira issue.

In response to this:

Version(s):
4.6+

Issue

Link to docs preview

QE review: ACS has no QE, approved by SME

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

@knortema knortema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfect. Well done!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. I have no inputs. Ship It!

@kcarmichael08 kcarmichael08 merged commit fea464f into openshift:rhacs-docs-main Sep 8, 2025
2 checks passed
@kcarmichael08
Copy link
Contributor Author

/cherrypick rhacs-docs-4.6
/cherrypick rhacs-docs-4.7
/cherrypick rhacs-docs-4.8
/cherrypick rhacs-docs-4.9

@openshift-cherrypick-robot

@kcarmichael08: new pull request created: #98661

In response to this:

/cherrypick rhacs-docs-4.6
/cherrypick rhacs-docs-4.7
/cherrypick rhacs-docs-4.8
/cherrypick rhacs-docs-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@kcarmichael08: new pull request created: #98662

In response to this:

/cherrypick rhacs-docs-4.6
/cherrypick rhacs-docs-4.7
/cherrypick rhacs-docs-4.8
/cherrypick rhacs-docs-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@kcarmichael08: new pull request created: #98663

In response to this:

/cherrypick rhacs-docs-4.6
/cherrypick rhacs-docs-4.7
/cherrypick rhacs-docs-4.8
/cherrypick rhacs-docs-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@kcarmichael08: new pull request created: #98664

In response to this:

/cherrypick rhacs-docs-4.6
/cherrypick rhacs-docs-4.7
/cherrypick rhacs-docs-4.8
/cherrypick rhacs-docs-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. rhacs-docs-4.6 rhacs-docs-4.7 rhacs-docs-4.8 rhacs-docs-4.9 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants