NO-ISSUE: Synchronize From Upstream Repositories #1208
Conversation
…ed tests with fail-fast:false (#3752) Signed-off-by: grokspawn <jordan@nimblewidget.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: 949fe13c235654013221b9e0c54efd549ac5bbf2
* 🌱 Bump the k8s-dependencies group across 1 directory with 9 updates Bumps the k8s-dependencies group with 4 updates in the / directory: [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver), [k8s.io/kube-aggregator](https://github.com/kubernetes/kube-aggregator), [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) and [sigs.k8s.io/controller-tools](https://github.com/kubernetes-sigs/controller-tools). Updates `k8s.io/apiextensions-apiserver` from 0.34.3 to 0.35.0 - [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases) - [Commits](kubernetes/apiextensions-apiserver@v0.34.3...v0.35.0) Updates `k8s.io/apimachinery` from 0.34.3 to 0.35.0 - [Commits](kubernetes/apimachinery@v0.34.3...v0.35.0) Updates `k8s.io/apiserver` from 0.34.3 to 0.35.0 - [Commits](kubernetes/apiserver@v0.34.3...v0.35.0) Updates `k8s.io/client-go` from 0.34.3 to 0.35.0 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.34.3...v0.35.0) Updates `k8s.io/code-generator` from 0.34.3 to 0.35.0 - [Commits](kubernetes/code-generator@v0.34.3...v0.35.0) Updates `k8s.io/component-base` from 0.34.3 to 0.35.0 - [Commits](kubernetes/component-base@v0.34.3...v0.35.0) Updates `k8s.io/kube-aggregator` from 0.34.3 to 0.35.0 - [Commits](kubernetes/kube-aggregator@v0.34.3...v0.35.0) Updates `sigs.k8s.io/controller-runtime` from 0.22.4 to 0.23.0 - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.22.4...v0.23.0) Updates `sigs.k8s.io/controller-tools` from 0.19.0 to 0.20.0 - [Release notes](https://github.com/kubernetes-sigs/controller-tools/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-tools/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/controller-tools@v0.19.0...v0.20.0) --- updated-dependencies: - dependency-name: k8s.io/apiextensions-apiserver dependency-version: 0.35.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies - dependency-name: k8s.io/apimachinery dependency-version: 0.35.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies - dependency-name: k8s.io/apiserver dependency-version: 0.35.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies - dependency-name: k8s.io/client-go dependency-version: 0.35.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies - dependency-name: k8s.io/code-generator dependency-version: 0.35.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies - dependency-name: k8s.io/component-base dependency-version: 0.35.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies - dependency-name: k8s.io/kube-aggregator dependency-version: 0.35.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies - dependency-name: sigs.k8s.io/controller-runtime dependency-version: 0.23.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies - dependency-name: sigs.k8s.io/controller-tools dependency-version: 0.20.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> * 🌱 Bump the kind tooling to match k8s 1.35 Signed-off-by: Todd Short <todd.short@me.com> * 🌱 Run make codegen and update exceptions Signed-off-by: Todd Short <todd.short@me.com> * 🌱 Fix make lint issues via nolint:staticcheck Specifically add the following. //nolint:staticcheck // SA1019: NewClientset not available until apply configurations are generated This is the simple solution; otherwise a _lot_ of code would need to be generated via the --with-applyconfig creating the NewClientset functions. Signed-off-by: Todd Short <todd.short@me.com> * 🐛 Fix unit tests for Kubernetes 1.35 fake client compatibility Fixes two test failures after K8s 1.35 upgrade: 1. Server-side apply status patch conversion for fake clients 2. WatchListClient feature incompatibility with fake clients causing timeouts The K8s 1.35 upgrade enabled WatchListClient by default, but fake clients don't support WatchList semantics properly. Disable the feature for tests via environment variable and wrap custom ListWatch with compatibility helper. Works around: kubernetes/kubernetes#135895 Signed-off-by: Todd Short <todd.short@me.com> Assisted-By: Claude --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Todd Short <todd.short@me.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: df41df4adf3dc66c0edb4b625a657972c25e5f89
Bumps the k8s-dependencies group with 1 update in the / directory: [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime). Updates `sigs.k8s.io/controller-runtime` from 0.23.0 to 0.23.1 - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.23.0...v0.23.1) --- updated-dependencies: - dependency-name: sigs.k8s.io/controller-runtime dependency-version: 0.23.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: ec75dd930ffdf091bdd3040abbd64162d7df5484
openshift-bot
added
approved
openshift-ci-robot
added
the
jira/valid-reference
|
@openshift-bot: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-bot: GitHub didn't allow me to request PR reviews from the following users: openshift/openshift-team-operator-framework. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: openshift-bot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: openshift-bot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest-required |
|
/verified bypass |
openshift-ci-robot
added
the
verified
|
@jianzhangbjz: The DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
/retest-required |
: [sig-cli] oc explain should contain proper spec+status for CRDs [Suite:openshift/conformance/parallel] expand_less | 30s
-- | --
{ fail [github.com/openshift/origin/test/extended/cli/explain.go:608]: Unexpected error: <*errors.errorString \| 0xc0015b8140>: Error running oc --namespace=e2e-test-oc-explain-2xzmz --kubeconfig=/tmp/configfile168747619 explain packagemanifests --api-version=packages.operators.coreos.com/v1: StdOut> GROUP: packages.operators.coreos.com KIND: PackageManifest VERSION: v1 StdErr> error: GVK map[group:packages.operators.coreos.com kind:PackageManifest version:v1] not found in OpenAPI schema exit status 1 : error: GVK map[group:packages.operators.coreos.com kind:PackageManifest version:v1] not found in OpenAPI schema { s: "Error running oc --namespace=e2e-test-oc-explain-2xzmz --kubeconfig=/tmp/configfile168747619 explain packagemanifests --api-version=packages.operators.coreos.com/v1:\nStdOut>\nGROUP: packages.operators.coreos.com\nKIND: PackageManifest\nVERSION: v1\nStdErr>\nerror: GVK map[group:packages.operators.coreos.com kind:PackageManifest version:v1] not found in OpenAPI schema\nexit status 1\n: error: GVK map[group:packages.operators.coreos.com kind:PackageManifest version:v1] not found in OpenAPI schema", } occurred} |
|
/retest-required |
|
/test e2e-gcp-ovn |
|
@openshift-bot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
go: downloading golang.org/x/text v0.23.0
CGO_ENABLED=1 KUBEBUILDER_ASSETS="/usr/local/kubebuilder/bin/" go test -mod=vendor -buildvcs=false -tags 'json1' -race -count=1 ./pkg/controller/... ./pkg/...
ok github.com/operator-framework/operator-lifecycle-manager/pkg/controller/bundle 2.179s
? github.com/operator-framework/operator-lifecycle-manager/pkg/controller/bundle/bundlefakes [no test files]
? github.com/operator-framework/operator-lifecycle-manager/pkg/controller/certs [no test files]
ok github.com/operator-framework/operator-lifecycle-manager/pkg/controller/errors 1.024s
ok github.com/operator-framework/operator-lifecycle-manager/pkg/controller/install 22.167s
Running Suite: Controller Suite - /go/src/github.com/openshift/operator-framework-olm/staging/operator-lifecycle-manager/pkg/controller/operators
=================================================================================================================================================
Random Seed: 1769677739
Will run 22 of 22 specs
••••panic: test timed out after 10m0s
running tests:
TestAPIs (10m0s)
goroutine 695 [running]:
testing.(*M).startAlarm.func1()
/usr/lib/golang/src/testing/testing.go:2682 +0x605
created by time.goFunc
/usr/lib/golang/src/time/sleep.go:215 +0x45 |
5 participants
The staging/ and vendor/ directories have been synchronized from the upstream repositories, pulling in the following commits:
This pull request is expected to merge without any human intervention. If tests are failing here, changes must land upstream to fix any issues so that future downstreaming efforts succeed.
/cc @openshift/openshift-team-operator-framework