Skip to content

OPRUN-4407: automate OCP-87276 #1212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Xia-Zhao-rh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OPRUN-4407: automate OCP-87276 #1212

Xia-Zhao-rh wants to merge 1 commit into from
+40 −5

Conversation

@Xia-Zhao-rh
Copy link
Contributor

@Xia-Zhao-rh Xia-Zhao-rh commented Jan 29, 2026 •
edited by openshift-ci bot
Loading

Add automated test for OCP-87276: Verify OCP 4.22 upgrade blocking messages

Summary

This PR adds automated test coverage for OCP-87276, which validates the ClusterOperator Upgradeable condition messages when incompatible operators block OCP 4.22 upgrades.

Changes

  1. New Helper Function (test/qe/util/olmv0util/helper.go)
  • Added CheckUpgradeMessage() function to verify ClusterOperator Upgradeable condition messages
  • Polls for 60 seconds to check if the message contains expected text
  • Complements existing CheckUpgradeStatus() for complete validation
  1. Enhanced Test Case 43101 (test/qe/specs/olmv0_defaultoption.go)
  • Added checkpoints 5-1 and 6-1 specifically for OCP 4.22 validation
  • Verifies upgrade blocking messages for operators with invalid/incompatible olm.maxOpenShiftVersion properties
  • Uses Major.Minor version comparison to correctly handle nightly/prerelease versions

Test Scenarios Covered

Checkpoint 5-1: After installing etcdoperator.v0.9.2 (empty maxOpenShiftVersion)

  • ✅ Verifies message contains: "upgrades to 4.23 or major version upgrades to 5.0"
  • ✅ Verifies message contains: "has invalid olm.maxOpenShiftVersion properties"

Checkpoint 6-1: After upgrading to etcdoperator.v0.9.4 (maxOpenShiftVersion: 4.9)

  • ✅ Verifies message contains: "upgrades to 4.23 or major version upgrades to 5.0"
  • ✅ Verifies message contains: "maximum supported OCP version"

Version Detection

Uses v.Major == 4 && v.Minor == 22 to correctly identify OCP 4.22 clusters, including:

  • Nightly builds: 4.22.0-0.nightly-2026-01-27-121451
  • RC builds: 4.22.0-rc.1
  • GA releases: 4.22.0, 4.22.1, etc.

Related

Assisted-by: Claude Code

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 29, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 29, 2026 •
edited by openshift-ci bot
Loading

@Xia-Zhao-rh: This pull request references OPRUN-4407 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Add automated test for OCP-87276: Verify OCP 4.22 upgrade blocking messages

Summary

This PR adds automated test coverage for OCP-87276, which validates the ClusterOperator Upgradeable condition messages when incompatible operators block OCP 4.22 upgrades.

Changes

  1. New Helper Function (test/qe/util/olmv0util/helper.go)
  • Added CheckUpgradeMessage() function to verify ClusterOperator Upgradeable condition messages
  • Polls for 60 seconds to check if the message contains expected text
  • Complements existing CheckUpgradeStatus() for complete validation
  1. Enhanced Test Case 43101 (test/qe/specs/olmv0_defaultoption.go)
  • Added checkpoints 5-1 and 6-1 specifically for OCP 4.22 validation
  • Verifies upgrade blocking messages for operators with invalid/incompatible olm.maxOpenShiftVersion properties
  • Uses Major.Minor version comparison to correctly handle nightly/prerelease versions

Test Scenarios Covered

Checkpoint 5-1: After installing etcdoperator.v0.9.2 (empty maxOpenShiftVersion)

  • ✅ Verifies message contains: "upgrades to 4.23 or major version upgrades to 5.0"
  • ✅ Verifies message contains: "has invalid olm.maxOpenShiftVersion properties"

Checkpoint 6-1: After upgrading to etcdoperator.v0.9.4 (maxOpenShiftVersion: 4.9)

  • ✅ Verifies message contains: "upgrades to 4.23 or major version upgrades to 5.0"
  • ✅ Verifies message contains: "maximum supported OCP version"

Version Detection

Uses v.Major == 4 && v.Minor == 22 to correctly identify OCP 4.22 clusters, including:

  • Nightly builds: 4.22.0-0.nightly-2026-01-27-121451
  • RC builds: 4.22.0-rc.1
  • GA releases: 4.22.0, 4.22.1, etc.

Related

Assisted-by: Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 29, 2026 •
edited by openshift-ci bot
Loading

@Xia-Zhao-rh: This pull request references OPRUN-4407 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Add automated test for OCP-87276: Verify OCP 4.22 upgrade blocking messages

Summary

This PR adds automated test coverage for OCP-87276, which validates the ClusterOperator Upgradeable condition messages when incompatible operators block OCP 4.22 upgrades.

Changes

  1. New Helper Function (test/qe/util/olmv0util/helper.go)
  • Added CheckUpgradeMessage() function to verify ClusterOperator Upgradeable condition messages
  • Polls for 60 seconds to check if the message contains expected text
  • Complements existing CheckUpgradeStatus() for complete validation
  1. Enhanced Test Case 43101 (test/qe/specs/olmv0_defaultoption.go)
  • Added checkpoints 5-1 and 6-1 specifically for OCP 4.22 validation
  • Verifies upgrade blocking messages for operators with invalid/incompatible olm.maxOpenShiftVersion properties
  • Uses Major.Minor version comparison to correctly handle nightly/prerelease versions

Test Scenarios Covered

Checkpoint 5-1: After installing etcdoperator.v0.9.2 (empty maxOpenShiftVersion)

  • ✅ Verifies message contains: "upgrades to 4.23 or major version upgrades to 5.0"
  • ✅ Verifies message contains: "has invalid olm.maxOpenShiftVersion properties"

Checkpoint 6-1: After upgrading to etcdoperator.v0.9.4 (maxOpenShiftVersion: 4.9)

  • ✅ Verifies message contains: "upgrades to 4.23 or major version upgrades to 5.0"
  • ✅ Verifies message contains: "maximum supported OCP version"

Version Detection

Uses v.Major == 4 && v.Minor == 22 to correctly identify OCP 4.22 clusters, including:

  • Nightly builds: 4.22.0-0.nightly-2026-01-27-121451
  • RC builds: 4.22.0-rc.1
  • GA releases: 4.22.0, 4.22.1, etc.

Related

Assisted-by: Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Xia-Zhao-rh
Copy link
Contributor Author

Xia-Zhao-rh commented Jan 29, 2026

/hold
wait nightly build

@openshift-ci openshift-ci bot requested review from bentito and grokspawn January 29, 2026 08:51
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 29, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Xia-Zhao-rh
Once this PR has been reviewed and has the lgtm label, please assign tmshort for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Xia-Zhao-rh
Copy link
Contributor Author

Xia-Zhao-rh commented Jan 29, 2026

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 29, 2026

@Xia-Zhao-rh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-olmv0-ext 9cced8b link true /test e2e-aws-olmv0-ext
ci/prow/e2e-gcp-ovn 9cced8b link true /test e2e-gcp-ovn
ci/prow/images 9cced8b link true /test images
ci/prow/e2e-upgrade 9cced8b link true /test e2e-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Xia-Zhao-rh
Copy link
Contributor Author

Xia-Zhao-rh commented Jan 30, 2026

/retest

@Xia-Zhao-rh
Copy link
Contributor Author

Xia-Zhao-rh commented Jan 30, 2026

/payload-job periodic-ci-openshift-operator-framework-olm-release-4.21-periodics-e2e-aws-ovn-extended-f1

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 30, 2026

@Xia-Zhao-rh: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-operator-framework-olm-release-4.21-periodics-e2e-aws-ovn-extended-f1

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cc6ebde0-fd86-11f0-922d-21fd84e0271b-0

@Xia-Zhao-rh
Copy link
Contributor Author

Xia-Zhao-rh commented Jan 30, 2026

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bentito bentito Awaiting requested review from bentito

@grokspawn grokspawn Awaiting requested review from grokspawn

Assignees

No one assigned

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Xia-Zhao-rh @openshift-ci-robot