WRKLDS-1716: test/extended/cli: Test oc create token #29895
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@tchap: This pull request references WRKLDS-1716 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
Conceptually you are right. But there is no test that exercises this upstream functionality against OCP cluster. Yes, we know that this works on vanilla Kubernetes. But we also have to know that oc create token works on OCP. So it is better to update our test to at least simply run create token. |
tchap
force-pushed
the
migrate-oc-serviceaccounts
branch
from
3d19e20 to
20b26b1
Compare
tchap
changed the title
|
@tchap: This pull request references WRKLDS-1716 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@tchap: This pull request references WRKLDS-1716 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
tchap
changed the title
|
Job Failure Risk Analysis for sha: 20b26b1
|
tchap
force-pushed
the
migrate-oc-serviceaccounts
branch
from
20b26b1 to
b0ff92d
Compare
|
Job Failure Risk Analysis for sha: b0ff92d
|
tchap
force-pushed
the
migrate-oc-serviceaccounts
branch
4 times, most recently
from
7bb4152 to
1d148d6
Compare
|
Job Failure Risk Analysis for sha: 1d148d6
|
The test is extended with checking the service account token as returned by oc create token.
tchap
force-pushed
the
migrate-oc-serviceaccounts
branch
from
1d148d6 to
de85e74
Compare
tchap
changed the title
|
@tchap: This pull request references WRKLDS-1716 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
@tchap: This pull request references WRKLDS-1716 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@tchap: This pull request references WRKLDS-1716 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@tchap: This pull request references WRKLDS-1716 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
tchap
changed the title
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, neisw, tchap The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
|
/retest-required |
|
/test e2e-aws-ovn-edge-zones |
|
@tchap: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Job Failure Risk Analysis for sha: de85e74
|
|
/test e2e-metal-ipi-ovn-ipv6 |
openshift-merge-bot
bot
merged commit a2a0ef9
into
openshift:main
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-tests |
Originally I was planning to remove tests for
oc serviceaccountsas I wanted to work on removing that group of deprecated subcommands, but I ended up postponing that. I still think we can merge the test change that extends the current tests to also checkoc create tokenand remove the associatedTODOnotes.oc serviceaccountscalls can be removed later and the test added here kept in place.