Add broker disk space cost #1604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
Mar 27, 2023
Contributor
chia7712
left a comment
chia7712
left a comment
There was a problem hiding this comment.
@qoo332001 感謝實作新功能，幾個建議請看一下
common/src/main/java/org/astraea/common/cost/BrokerDiskSpaceCost.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/astraea/common/cost/BrokerDiskSpaceCost.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/astraea/common/cost/BrokerDiskSpaceCost.java
Outdated
Show resolved
Hide resolved
…rokerDiskSpaceCost
Collaborator
Author
|
@chia7712 做了一些更新，麻煩在看一次，謝謝 |
chia7712
reviewed
Mar 31, 2023
chia7712
reviewed
Mar 31, 2023
Contributor
chia7712
left a comment
chia7712
left a comment
There was a problem hiding this comment.
@qoo332001 感謝快速的修正，還有幾個建議請看一下
common/src/main/java/org/astraea/common/cost/BrokerDiskSpaceCost.java
Outdated
Show resolved
Hide resolved
…rokerDiskSpaceCost
chia7712
reviewed
Apr 10, 2023
Contributor
chia7712
left a comment
chia7712
left a comment
There was a problem hiding this comment.
@qoo332001 感謝功能和修正，請再看一下 cluster info 中有哪些方法要移動到 costutils
另外可否開一隻議題來展示一下這個功能？並且在隨後寫成一個簡單的報告發成PR
…rokerDiskSpaceCost
garyparrot
reviewed
May 2, 2023
…rokerDiskSpaceCost
chia7712
reviewed
May 9, 2023
common/src/main/java/org/astraea/common/cost/BrokerDiskSpaceCost.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
May 9, 2023
common/src/main/java/org/astraea/common/cost/BrokerDiskSpaceCost.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
May 9, 2023
common/src/main/java/org/astraea/common/cost/BrokerDiskSpaceCost.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
May 10, 2023
Contributor
chia7712
left a comment
chia7712
left a comment
There was a problem hiding this comment.
@qoo332001 感謝更新功能，幾個建議請再看一下
common/src/main/java/org/astraea/common/cost/BrokerDiskSpaceCost.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/astraea/common/cost/BrokerDiskSpaceCost.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/astraea/common/cost/BrokerDiskSpaceCost.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/astraea/common/cost/BrokerDiskSpaceCost.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
新增
BrokerDiskSpaceCost來限制搬移過程中最多會佔用的broker/data path空間