Fix issues blocking rerun of config phase#1344
Merged
freyes merged 1 commit intoopenstack-charmers:masterfrom Apr 22, 2026
Merged
Fix issues blocking rerun of config phase#1344freyes merged 1 commit intoopenstack-charmers:masterfrom
freyes merged 1 commit intoopenstack-charmers:masterfrom
Conversation
Contributor
Author
|
still testing |
dosaboy
force-pushed
the
fix-configure-retry
branch
from
b1b6115 to
eb824df
Compare
Contributor
Author
|
tested fresh run and re-run. seems good. |
freyes
requested changes
Apr 22, 2026
Vault get_csr() and octavia-diskimage-retrofit will fail if re-run after a successful run so we now protect against this. Fixes: openstack-charmers#1343
dosaboy
force-pushed
the
fix-configure-retry
branch
from
eb824df to
66214c7
Compare
freyes
approved these changes
Apr 22, 2026
Member
freyes
left a comment
freyes
left a comment
There was a problem hiding this comment.
LGTM. Thanks for addressing the feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vault get_csr() and octavia-diskimage-retrofit will fail if re-run after a successful run so we now protect against this.
Fixes: #1343