Add retry mechanism for the Launchpad API#686
Merged
freyes merged 1 commit intoopenstack-charmers:masterfrom Apr 22, 2026
Merged
Add retry mechanism for the Launchpad API#686freyes merged 1 commit intoopenstack-charmers:masterfrom
freyes merged 1 commit intoopenstack-charmers:masterfrom
Conversation
Quite often Launchpad API is temporarily unavailable. In such cases, without this patch, a request to get all Ubuntu releases from Launchpad fails immediately, causing the entire test to fail. For example for the charm-octavia it can take up to 2 hours before the functional tests get to this point. And if it fails because of the Launchapad API unavailability, the whole tests suite needs to be restarted. In order to save time and resources, a simple request retry mechanism is introduced by this patch. Signed-off-by: Marcin Wilk <marcin.wilk@canonical.com>
wilkmar
force-pushed
the
retry_launchpad_request
branch
from
c760cf7 to
4fa84bf
Compare
dosaboy
approved these changes
Apr 22, 2026
dosaboy
left a comment
dosaboy
left a comment
There was a problem hiding this comment.
I have done a run of charmed-openstack-tester with this patch included in an environment that frequently has connection failures to Launchpad and it worked well for me.
freyes
approved these changes
Apr 22, 2026
Member
|
The CI was stuck, it has no relation to this change, there is something with the ntp charm and the github runner, they don't reach the desired state, I've seen it. I won't block this change on that CI issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quite often Launchpad API is temporarily unavailable. In such cases, without this patch, a request to get all Ubuntu releases from Launchpad fails immediately, causing the entire test to fail. For example for the charm-octavia it can take up to 2 hours before the functional tests get to this point. And if it fails because of the Launchapad API unavailability, the whole tests suite needs to be restarted. In order to save time and resources, a simple request retry mechanism is introduced by this patch.