no-wait option in tests.yaml#688
Open
hemanthnakkina wants to merge 2 commits intoopenstack-charmers:masterfrom
Open
no-wait option in tests.yaml#688hemanthnakkina wants to merge 2 commits intoopenstack-charmers:masterfrom
hemanthnakkina wants to merge 2 commits intoopenstack-charmers:masterfrom
Conversation
hemanthnakkina
force-pushed
the
no-wait-tests-yaml
branch
from
aca7203 to
869a40a
Compare
There was a problem hiding this comment.
Pull request overview
Adds a tests_options.no_wait_deploy setting in tests.yaml to allow selectively skipping deployment waiting so multi-bundle functional test runs can proceed to configuration sooner and reduce overall runtime.
Changes:
- Introduces
utils.no_wait_deploy()to readtests_options.no_wait_deploy(per bundle). - Wires the option into
func_test_runner.run_env_deployment()to passwait=intodeploy.deploy()and to conditionally skip the post-deploy settle wait. - Adds unit tests for the new config option and runner behavior; documents the new
tests.yamloption.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| zaza/charm_lifecycle/utils.py | Adds no_wait_deploy() config helper for reading tests_options.no_wait_deploy. |
| zaza/charm_lifecycle/func_test_runner.py | Applies no_wait_deploy to deployment waiting behavior in the lifecycle runner. |
| unit_tests/test_zaza_charm_lifecycle_utils.py | Adds unit coverage for no_wait_deploy() config parsing behavior. |
| unit_tests/test_zaza_charm_lifecycle_func_test_runner.py | Updates expected deploy calls to include wait=... and adds a no-wait runner test. |
| doc/source/addingcharmtests.rst | Documents the new tests_options.no_wait_deploy option. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
freyes
requested changes
Mar 27, 2026
To run multiple bundles in different models, zaza
need to wait for first bundle applications to acheive
status as specified in target_deploy_status before
deploying second bundle using configure. (Deploying
second bundle using configure is actually a hacky
way). This increases the time of deployment as both
bundles are deployed sequentially. sunbeam-charms
project has total timeout of 2 hours for its
functional test.
Add option no-wait in tests.yaml so that zaza did not
wait for target_deploy_status for the applications and
proceed with configure.
tests_options:
no_wait_deploy:
smoke
The option --no-wait already exists for functest-deploy
cli command.
hemanthnakkina
force-pushed
the
no-wait-tests-yaml
branch
from
869a40a to
2db6524
Compare
Member
|
The ntp charm app is failing, and we have no logs to troubleshoot, we need to fix the CI. |
Use a unique artifact name per matrix job by combining the bundle name and the juju_channel. Since artifact names cannot contain '/', sanitize the channel value (e.g. 2.9/stable -> 2.9-stable) via a prior step before passing it to actions/upload-artifact. Co-authored-by: GitHub Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To run multiple bundles in different models, zaza
need to wait for first bundle applications to acheive status as specified in target_deploy_status before deploying second bundle using configure. (Deploying second bundle using configure is actually a hacky
way). This increases the time of deployment as both bundles are deployed sequentially. sunbeam-charms
project has total timeout of 2 hours for its
functional test.
Add option no-wait in tests.yaml so that zaza did not wait for target_deploy_status for the applications and proceed with configure.
The option --no-wait already exists for functest-deploy cli command.