Refactoring kuttl tests for better execution#402
Open
fmount wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Open
Refactoring kuttl tests for better execution#402fmount wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
fmount wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
Kuttl tests are currently hard to follow, because we literally assert the entire resources associated to a Manila deployment. This patch aims to produce a big refactoring of the current kuttl testing, to achieve the following results: 1. Only match, within the deployed resources, what is meaningful to make the test fail or pass 2. Reorganize kuttl tests in test suites, so we don't have to specify the testDirs via cli but they live within the main kutt-test.yaml config file Signed-off-by: Francesco Pantano <fpantano@redhat.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmount The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fmount
added a commit
to fmount/install_yamls
that referenced
this pull request
Mar 20, 2025
This patch aligns install_yamls to run manila kuttl tests using the new form introduced by the code refactoring [1]. [1] openstack-k8s-operators/manila-operator#402 Signed-off-by: Francesco Pantano <fpantano@redhat.com>
|
This change depends on a change that failed to merge. Change openstack-k8s-operators/install_yamls#1027 is needed. |
Contributor
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kuttl tests are currently hard to follow, because we literally assert the entire resources associated to a Manila deployment. This patch aims to produce a big refactoring of the current kuttl testing, to achieve the following results:
testDirsvia cli because they have a dedicatedkutt-test.yamlconfig fileDepends-On: openstack-k8s-operators/install_yamls#1027