make iD 2x faster during long edit sessions #11861
Open
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
approved these changes
Feb 10, 2026
Collaborator
1ec5
left a comment
1ec5
left a comment
There was a problem hiding this comment.
This calls for a blog post or diary entry or something. 📉
Contributor
|
It's one of those things where you're happy for the improvement, but embarrassed about the reason. |
Dimitar5555
reviewed
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For changesets that last several hours and affect thousands of elements (example),
coreHistory's stack quickly reaches >1GB of JSON, which makeshistory.toJSON()the perf bottleneck.Over 99% of time is spent inside this function after ever operation, and we call the function twice in a row for no good reason. We can just reuse the value from a few lines above