Skip to content

Conversation

Copy link

Copilot AI commented Feb 12, 2026

Country fields were unconditionally excluded from raw value styling, even when containing invalid country codes. This prevented visual indication of malformed data.

Changes

  • Modified isRawValue() logic in modules/ui/fields/combo.js:777: Now validates country code values against buildCountry() map before excluding from raw value treatment
// Before: all country field values excluded
&& !osmIsoCountryKeys.has(field.key);

// After: only valid country codes excluded  
&& !(osmIsoCountryKeys.has(field.key) && value in buildCountry());

Behavior:

  • Valid ISO codes (e.g., US, GB) → not styled as raw
  • Invalid codes (e.g., invalid, XX) → styled as raw

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • api.panoramax.xyz
    • Triggering command: /opt/hostedtoolcache/node/24.13.0/x64/bin/node /opt/hostedtoolcache/node/24.13.0/x64/bin/node --conditions node --conditions development --experimental-import-meta-resolve --require /home/REDACTED/work/iD/iD/node_modules/vitest/suppress-warnings.cjs /home/REDACTED/work/iD/iD/node_modules/vitest/dist/workers/forks.js (dns block)
  • cdn.jsdelivr.net
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node scripts/build_data.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 3 commits February 12, 2026 09:28
Co-authored-by: k-yle <16009897+k-yle@users.noreply.github.com>
Co-authored-by: k-yle <16009897+k-yle@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix bug in combo.js at line 777 Fix raw value detection for country fields with invalid codes Feb 12, 2026
Copilot AI requested a review from k-yle February 12, 2026 09:35
Copy link
Collaborator

@k-yle k-yle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well that was a massive waste of electricity... but it does fix #11783 (comment)

Image

@k-yle k-yle marked this pull request as ready for review February 12, 2026 09:47
@Razen04
Copy link
Contributor

Razen04 commented Feb 12, 2026

This works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants