-
Notifications
You must be signed in to change notification settings - Fork 220
Add recommended sauna related fields from 'leisure=sauna' Wikipage #1658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
tordans
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome and thank you for helping improving the presets!
I just left a few comments while on the go and approved the preview-generation.
The thinks I want to look into more:
- facility vs sauna-„room“ — some fields make sense in the facility. Others only in the „rool“
- Unisex: we make a strong suggestion to use one tag over the others. We need to double check if there is agreement on this
- Labels: I think we need to make them shorter…
will look into it more some other time.
| { | ||
| "key": "gender_segregated", | ||
| "type": "check", | ||
| "label": "Gender separated areas or timeslots" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thing the label needs to be shorter to look well in the UI. We will see..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The UI should be yes/no/nil (unknown, default).
AFAIK we can have the value yes an a label that is more descriptive. That could help with getting the field label shorter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: does the wiki talk about areas and timeslots? Do we map one sauna-room or the facility?; and what would the area be when it is a room? Or how would we map the room when the facility is meant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your comments. I've understood that this tag could mean both area and timeslot.
At least here in Finland there are 3 very common types of saunas:
-
Unisex sauna (where everyone typically wears swimming wear)
-
Different sauna rooms for different sexes eg section for men and section for women.
-
One sauna room where they have separate timeslots for men and women.
I would understand that both 2 & 3 mean gender_segregated=yes but I'm happy to remove the timeslot interpretation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But in order to make this PR smaller I can also remove the gender_segregated field and we can do it in a different PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested how that label looks in UI using PR build preview?
data/fields/sauna.json
Outdated
| "hot": "Finnish Sauna over > 60°C", | ||
| "steam": "Steam Sauna", | ||
| "smoke": "Smoke Sauna", | ||
| "dry": "Sauna without throwing water", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ZeLonewolf Is "Sauna without throwing water" sounding good to native speaker?
it seems weird to me but I am neither sauna specialist nor English specialist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah indeed this was not great choice of words. I will convert this to "Dry Sauna".
data/fields/sauna.json
Outdated
| "label": "Sauna type", | ||
| "strings": { | ||
| "options": { | ||
| "hot": "Finnish Sauna over > 60°C", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
base language of iD presets is EN-US and USA as far as I know is using some own temperature units
no idea how to deal with it, maybe it should be ignored?
| { | ||
| "key": "sauna:water", | ||
| "type": "check", | ||
| "label": "Throwing water on the sauna stove" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is both and "dry": "Sauna without throwing water", option needed? Seems to be tagging double single piece of info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well one doesn't normally throw water in steam sauna either.
Then there are normal hot saunas where throwing water is not allowed either.
It really depends.
This really makes a difference in the varm sauna.
|
"Sauna without throwing water" sounds like gibberish. Wet sauna or dry
sauna are the terms.
https://musclelab.la/blogs/dry-sauna-vs-wet-sauna-what-s-the-difference-and-which-to-choose
…On Tue, Oct 21, 2025, 4:48 AM Mateusz Konieczny ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In data/fields/sauna_water.json
<#1658 (comment)>
:
> @@ -0,0 +1,5 @@
+{
+ "key": "sauna:water",
+ "type": "check",
+ "label": "Throwing water on the sauna stove"
is both and "dry": "Sauna without throwing water", option needed? Seems
to be tagging double single piece of info
—
Reply to this email directly, view it on GitHub
<#1658 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAY2OSQ3OUU2IVETLEFM3VD3YXXNPAVCNFSM6AAAAACDRALFU6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGNJZGQ4DIMJVGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
matkoniecz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
per @ZeLonewolf "Sauna without throwing water" should be removed/changed unless other English experts disagree
|
The problem is that @ZeLonewolf comes from a totally different culture and yes internationally these 2 are the most common ones and they are the most boring saunas there are. In Finland we have a separate word "löyly" which means the water thrown into the heater which then converts into a steam. The sauna is still very warm so in 80-100°C (176-212°F). If you are interested you can watch this 4 minute video: So there's a major difference between a hot sauna and a sauna where throwing water is allowed. Because of this I wouldn't really want to remove the water allowed option and this is the reason I added it there. The link that @ZeLonewolf shared is content about saunas in the gyms or hotels. Not the ones we have in the north and in some parts of europe. Koreans are nice that they have their own distinguished separate word (Hanjeungmak) for the sauna style that they have. The finnish sauna means a hot sauna room and always being able to throw the water too. If this can somehow be described in a short field I would be very happy to modify this PR. This style of saunas are the most common ones everywhere in the nordics and baltics. There are some saunas like these elsewhere but they are not as common. |
The obvious solution for an English label is simply |
|
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
|
I modified the texts to match the suggestion from @ZeLonewolf 👍 |
Description, Motivation & Context
I feel that sauna related tags are very well documented in the wiki.
But adding them for example in Go map!! is not very straightforward because these fields are not automatically shown.
I'm from Finland 🇫🇮 and we have ~5.5 million people and ~1.5 million saunas but only very few of them exist in OSM.
I hope that these changes will make it easier to contribute to OSM to let people enjoy sauna in more places 🧖♂️ 🧖♀️.
I'm new here and I'm not sure if I did everything correctly but I'm happy to learn 🙇
Related issues
Links and data
https://wiki.openstreetmap.org/wiki/Tag:leisure%3Dsauna
Relevant tag usage stats:
Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.