ipaddr resolution cache implementation, nsenter fix #964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/var/lib/opensvc/cache/addrinfo/<name> files contain the resolved ipaddr. When the name resolution does not work, the cache files content is trusted for 16m. After that duration, the ip resource status is considered undef and we now longer accept to stop or start the resource as we don't know the addr.
With micro-containers we used "nsenter -e" but this can hang with certain /proc/<pid>/environ contents. Parse the container process environ ourselves and pass the env to the exec.Command. Don't use -e anymore.
So the secondary instance is ready to refetch when the up instance status is next refreshed. This patch fixes a case where the file was never refetched when the admin removed the file from a secondary node in the hope to demonstrate how opensvc handles resync automatically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.