Skip to content

[GenAI] Fix cgo callback pointer handling in genai #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
zxjzxj9 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[GenAI] Fix cgo callback pointer handling in genai #1024

zxjzxj9 wants to merge 1 commit into from
+25 −4

Conversation

@zxjzxj9
Copy link

@zxjzxj9 zxjzxj9 commented Dec 10, 2025

  • wrap Sequence in cgo.Handle before passing into C callbacks
  • unwrap handle in goCallbackBridge and delete after generation
  • prevents cgo “Go pointer to Go pointer” panic during OpenVINO runs
  • make cgo compatible accross different openvino versions

@zxjzxj9 zxjzxj9 requested a review from a team as a code owner December 10, 2025 12:47
@zxjzxj9
[GenAI] Fix cgo callback pointer handling in genai
4482294 
- wrap Sequence in cgo.Handle before passing into C callbacks
- unwrap handle in goCallbackBridge and delete after generation
- prevents cgo “Go pointer to Go pointer” panic during OpenVINO runs
- make cgo compatible accross different openvino versions
@zxjzxj9 zxjzxj9 force-pushed the fix-ubuntu24-2025.4 branch from 39d349d to 4482294 Compare December 10, 2025 12:50
@zhaohb
Copy link
Contributor

zhaohb commented Dec 10, 2025

Greate, thank you so much for your contribution. However, it overlaps a bit with previous PR features; I'll consider how to merge them.

@zxjzxj9
Copy link
Author

zxjzxj9 commented Dec 23, 2025

Hi @zhaohb, is there any update for this MR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zxjzxj9 @zhaohb