Don't force KMP resources on apps. #1492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be possible to use multipaz-compose in Android apps using Android resources and not KMP resources. As such, we shouldn't be passing around things like `DrawableResource` since that's a KMP resource construct. Change `CredentialManagerPresentmentActivity`, `MdocNfcPresentmentActivity`, and `UriSchemePresentmentActivity` so their settings classes take a `@Composable () -> Painter` lambda instead. Fixes #1459. Test: Manually tested. Signed-off-by: David Zeuthen <zeuthen@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be possible to use multipaz-compose in Android apps using Android resources and not KMP resources. As such, we shouldn't be passing around things like
DrawableResourcesince that's a KMP resource construct. ChangeCredentialManagerPresentmentActivity,MdocNfcPresentmentActivity, andUriSchemePresentmentActivityso their settings classes take a@Composable () -> Painterlambda instead.Fixes #1459.
Test: Manually tested.