Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds support for the MP1 (solar-lunar diurnal) tidal constituent, which represents the interaction between the M2 (lunar semi-diurnal) and P1 (solar diurnal) constituents.
Changes:
- Added MP1 constituent definition as a compound constituent (M2 - P1)
- Added test coverage for the MP1 constituent to verify correct speed calculation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/tide-predictor/src/constituents/MP1.ts | Defines the MP1 constituent as a compound constituent combining M2 and P1 with subtraction |
| packages/tide-predictor/test/constituents/index.test.ts | Adds test case to verify MP1 is properly defined and has the correct speed value |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes openwatersio/tide-database#36.