Conversation
514bda0 to
5d941f9
Compare
ed6768c to
b8fd033
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds functionality to import 4,838 global tide stations from the TICON-4 (TIdal CONstants based on GESLA-4) dataset. The implementation includes a bash script to download the data, a TypeScript module to parse and convert the data to the repository's station JSON schema, and a new utility module for computing tidal datums.
Key changes:
- New import tooling for TICON-4 dataset with automatic data download and processing
- New datum computation utilities using synthetic tidal predictions
- Updated @neaps/tide-predictor dependency to version 0.3.0 to support additional harmonic constituents
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/import-ticon | Bash script that downloads TICON-4 data and invokes the TypeScript import script |
| tools/import-ticon.ts | TypeScript module that parses TICON-4 CSV files and converts stations to JSON schema |
| tools/datum.ts | New utility module for computing tidal datums from harmonic constituents using synthetic predictions |
| package.json | Updates @neaps/tide-predictor dependency from 0.2.1 to 0.3.0 |
| .gitignore | Adds tmp directory to exclude downloaded data from version control |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merged
679ff9b to
5bef153
Compare
…so copilot can focus on more meaningful feedback
Merged
Contributor
Author
I'm going to leave this for now. Later I can add a way to load data by source or filter out likely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a script to import stations from TICON-4, TIdal CONstants based on GESLA-4 sea-level records.
It includes 4,838 global stations.
TODO:
Resolve duplicates between NOAA/TICON. It might make sense to just skip any that are from NOAA in TICON, but I want to compare the list and see if there are any differences.