Skip to content

[feature] Added make html SKIP_YARN=1#171

Merged
nemesifier merged 1 commit intomasterfrom
features/skip-yarn
Feb 3, 2026
Merged

[feature] Added make html SKIP_YARN=1#171
nemesifier merged 1 commit intomasterfrom
features/skip-yarn

Conversation

@nemesifier
Copy link
Member

Added make html SKIP_YARN=1.

@nemesifier nemesifier self-assigned this Feb 3, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 3, 2026

Walkthrough

This pull request introduces an optional SKIP_YARN flag to the Makefile that allows users to skip yarn asset rebuilding during the build process. The flag defaults to 0 (build normally) and can be set to 1 via command-line argument (e.g., make html SKIP_YARN=1). A conditional statement wraps the yarn build step to honor this flag. Documentation in README.rst is updated with an example showing this usage pattern for scenarios where only content changes are being made.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main feature being added: support for the SKIP_YARN=1 flag with the make html command.
Description check ✅ Passed The description is directly related to the changeset, accurately summarizing the addition of SKIP_YARN=1 support for the make html command.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch features/skip-yarn

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@Makefile`:
- Line 46: Update the help echo string that currently shows "make SKIP_YARN=1
html" to match the README ordering by using "make html SKIP_YARN=1"; locate the
echo in the Makefile that prints the SKIP_YARN example and replace the example
command text only so both docs are consistent.
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2a843d3 and b4e2ced.

📒 Files selected for processing (2)
  • Makefile
  • README.rst
🔇 Additional comments (2)
Makefile (1)

29-52: SKIP_YARN gating looks solid.

Defaulting to 0 preserves existing behavior, and the conditional cleanly skips yarn build when requested.

README.rst (1)

28-30: Docs update is clear and helpful.

The example accurately reflects the new SKIP_YARN behavior and provides good context for when to use it.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

@echo ' '
@echo 'Set the DEBUG variable to 1 to enable debugging, e.g. make DEBUG=1 html '
@echo 'Set the RELATIVE variable to 1 to enable relative urls '
@echo 'Set the SKIP_YARN variable to 1 to skip yarn build, e.g. make SKIP_YARN=1 html'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Align the SKIP_YARN example ordering with README.

The help text uses make SKIP_YARN=1 html while README shows make html SKIP_YARN=1. Both work, but consistent ordering avoids confusion.

Suggested text tweak
-	`@echo` 'Set the SKIP_YARN variable to 1 to skip yarn build, e.g. make SKIP_YARN=1 html'
+	`@echo` 'Set the SKIP_YARN variable to 1 to skip yarn build, e.g. make html SKIP_YARN=1'
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
@echo 'Set the SKIP_YARN variable to 1 to skip yarn build, e.g. make SKIP_YARN=1 html'
`@echo` 'Set the SKIP_YARN variable to 1 to skip yarn build, e.g. make html SKIP_YARN=1'
🤖 Prompt for AI Agents
In `@Makefile` at line 46, Update the help echo string that currently shows "make
SKIP_YARN=1 html" to match the README ordering by using "make html SKIP_YARN=1";
locate the echo in the Makefile that prints the SKIP_YARN example and replace
the example command text only so both docs are consistent.

@nemesifier nemesifier merged commit b4e2ced into master Feb 3, 2026
3 checks passed
@nemesifier nemesifier deleted the features/skip-yarn branch February 4, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant