kplex: add support for Sierra Wireless Gobi GPS#15702
Merged
neheb merged 1 commit intoopenwrt:masterfrom Jul 15, 2021
Merged
Conversation
Sierra Wireless modems need the string '$GPS_START' to be sent to the GPS tty device as only then the modem firmware starts emitting NMEA-0183 sentences. Add an option 'sierragpsstart' to kplex' serial driver to support that quirk as kplex can be very useful to spread GPS data over the network while also supplying 'ugps' using a PTY, allowing for correct system time to be set automatically on boot up from GPS. This patch is also PR'ed at the upstream project: stripydog/kplex#54 Signed-off-by: Daniel Golle <daniel@makrotopia.org>
dangowrt
force-pushed
the
kplex-sierra-gps-start
branch
from
e43dfd8 to
8790d3a
Compare
Member
|
We should give upstream some time to consider your pull request... |
Member
Author
Sure, but that shouldn't hinder us from reviewing and testing it for inclusion in OpenWrt packages.git in the meantime. In the end, using the built-in GNSS of LTE modems with kplex is mostly relevant when using routers which contains those modems and run OpenWrt. Hence I was hoping to back the upstream PR by illustrating its usefulness downstream and also make it available for users, as upstream hasn't been active for more than 6 months it can take some time... PS: I'm also planning to suggest a hotplug-script for kplex taking care of restarting the service in case of a relevant tty device being added. |
nunojpg
approved these changes
May 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintainer: @nunojpg
Compile tested: aarch64-cortexa53, mediatek/mt7622
Run tested: BananaPi BPi-R64 with Sierra Wireless EM7455, OpenWrt SNAPSHOT r16799 openwrt/openwrt@7131f5a2fb
Description:
Sierra Wireless modems need the string
$GPS_STARTto be sent to the GPS tty device as only then the modem firmware starts emitting NMEA-0183 sentences.Add an option 'sierragpsstart' to kplex' serial driver to support that quirk as kplex can be very useful to spread GPS data over the network while also supplying 'ugps' using a PTY, allowing for correct system time to be set automatically on boot up from GPS.
This patch is also PR'ed at the upstream project:
stripydog/kplex#54
Signed-off-by: Daniel Golle daniel@makrotopia.org