Skip to content

Conversation

@CodeFetch
Copy link
Contributor

Removes the BUILDONLY flag as otherwise no packages will be created.

@oskarirauta

@neheb
Copy link
Contributor

neheb commented Jun 16, 2021

Commit sha: 6e5880b, Author: Vincent Wiemann, Committer: GitHub; Expected "Vincent Wiemann vincent.wiemann@ironai.com", but got "Vincent Wiemann me@bibbl.com".

Removes the BUILDONLY flag as otherwise no packages will be created.

Signed-off-by: Vincent Wiemann <vincent.wiemann@ironai.com>
@CodeFetch
Copy link
Contributor Author

@neheb Thanks for the hint! One more reason to not use Github's web interface for committing.

@neheb neheb merged commit 89e9a1a into openwrt:master Jun 17, 2021
@BKPepe
Copy link
Member

BKPepe commented Jun 17, 2021

Where is approve from maintaner? 👀

@CodeFetch
Copy link
Contributor Author

@BKPepe This was a point of discussion right from the beginning. #15643 (comment)

We have tested it and no packages will be created with the BUILDONLY flag set and the files are missing in rootfs. @oskarirauta said that something did not work, but I can't confirm that. The BUILDONLY flag is used for packages which are only used as build dependencies. It's wrong to use it here.

@BKPepe
Copy link
Member

BKPepe commented Jun 17, 2021

Well, don't take it wrong, but what's the point of being maintainer if he didn't approve it and it is merged no matter what? 1 or 2 days from my point of view are not enough to review the things!

Based on your comment, I could see that we don't need to have maintainers at all and that's why they are leaving like #15853

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants