-
Notifications
You must be signed in to change notification settings - Fork 3.8k
v2ray-geodata: provide a virtual package #28235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Switch v2ray-geodata provides to use the new virtual provides semantic that enables v2ray-geoip and v2ray-geosite to be installed side-by-side. Related: openwrt/openwrt#21288 Fixes: openwrt#28235 Signed-off-by: TeleostNaCl Dai <teleostnacl@gmail.com>
532175d to
0b2e822
Compare
|
Hello @GeorgeSapkin, could you please help review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your commit message points to this PR in Fixes:. Did you mean to point it to another issue perhaps?
Edit: I usually omit empty lines between Related, Fixes and sign-off.
Switch v2ray-geodata provides to use the new virtual provides semantic that enables v2ray-geoip and v2ray-geosite to be installed side-by-side. Related: openwrt/openwrt#21288 Fixes: openwrt#28235 Signed-off-by: TeleostNaCl Dai <teleostnacl@gmail.com>
0b2e822 to
21bd45c
Compare
Switch v2ray-geodata provides to use the new virtual provides semantic that enables v2ray-geoip and v2ray-geosite to be installed side-by-side. Related: openwrt/openwrt#21288 Related: openwrt#28235 Signed-off-by: TeleostNaCl Dai <teleostnacl@gmail.com>
21bd45c to
964ca66
Compare
|
Hello @GeorgeSapkin I have omitted unnecessary empty lines. And I want to relate this PR in the commit for future reference, so maybe using “Related” would be more appropriate. |
|
I don't think there's any meaningful additional context in this PR compared to the commit description. |
|
Also you should use a GitHub username when specifying maintainers in a PR, and not a name and an email. |
|
I have edited the Maintainer and Description, please check it again, thanks a lot! |
|
And since this is modifying packaging information, you should bump the |
Switch v2ray-geodata provides to use the new virtual provides semantic that enables v2ray-geoip and v2ray-geosite to be installed side-by-side. Related: openwrt/openwrt#21288 Related: openwrt#28235 Signed-off-by: TeleostNaCl Dai <teleostnacl@gmail.com>
964ca66 to
be0456c
Compare
I’m sorry I forgot this important detail. And now I have bumped the |
📦 Package Details
Maintainer:
@1715173329 Tianling Shen cnsztl@immortalwrt.org
Description:
According to openwrt/openwrt#21288, switch v2ray-geodata provides to use the new virtual provides semantic that enables v2ray-geoip and v2ray-geosite to be installed side-by-side.
This resolves the conflict between the v2ray-geoip and v2ray-geosite packages during
make package/install.Without this PR, the following error occurs when running
make package/install:🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.