ddns-scripts: add multiple DNS records support for aliyun ddns #28271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monokoo
force-pushed
the
patch-1
branch
6 times, most recently
from
ab2bef1 to
1a567ab
Compare
Added logic to extract and match DNS record ID from parameters, with fallback to default selection if no match is found. Signed-off-by: QiLei Niu <qilei.niu@gmail.com>
Author
|
@GeorgeSapkin thanks |
Member
|
In the future you shouldn't open multiple PRs for the same changes, and update the original one instead (#28055) as now the discussion is lost. And you should use the PR template and tag the package maintainer. |
Author
Thanks for your advice, next time I will preserve the PR template information and maintain it in the same PR. Thank you again. |
feckert
requested changes
Jan 9, 2026
Member
feckert
left a comment
feckert
left a comment
There was a problem hiding this comment.
Can we not move the change into a subfunction?
| if [ -n "$specRecordId" ]; then | ||
| write_log 7 "specRecordId: ${specRecordId}" | ||
| idx=1 | ||
| while json_is_a $idx object |
Member
There was a problem hiding this comment.
Please use the pattern while <xxxx>; do
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ddns-scripts: Added logic to extract and match DNS record ID from parameters,
with fallback to default selection if no match is found.