A selection of new Lua packages #2855

maxguru · 2016-06-14T02:40:25Z

No description provided.

karlp · 2016-06-30T16:17:25Z

lang/cgilua/Makefile

+endef
+
+define Build/Configure
+endef


don't need this block.

Can you please clarify? Why? Which block exactly? I'm pretty sure define Package/cgilua is needed. Maybe define Build/Configure?

Yes, the configure blocks. (in all these packages)

Please take a look at my fix.

diizzyy · 2017-01-07T10:42:04Z

@karlp
Can you please have a look at this?

karlp · 2017-01-09T10:51:57Z

lang/cgilua/Makefile

@@ -0,0 +1,61 @@
+#
+# Copyright (C) 2016 OpenWrt.org


This is not correct. You aren't OpenWrt. Either drop teh copyright outright (my choice) or provide your own name here. (will apply in all places)

I was under the impression that was required. I'll fix it.

Actually, according to this I can use OpenWrt.

It's incorrect unfortunately. Either drop it as karlp suggests or add your own.

diizzyy · 2017-01-09T10:53:49Z

lang/cgilua/Makefile

+PKG_VERSION:=5.1.4
+PKG_RELEASE:=1
+
+PKG_SOURCE:=v$(PKG_VERSION).tar.gz


This is a no go, use the git approach instead including xz tarballs.

Why not? What rule does this break?

You'll run into file names clashing if they having nothing more than v(version).tar.gz as file name.

karlp · 2017-01-09T10:56:29Z

lang/cgilua/Makefile

+define Package/cgilua/install
+	$(INSTALL_DIR) $(1)/$(LUA_MODULE_PATH)/cgilua
+	$(INSTALL_DATA) $(PKG_BUILD_DIR)/src/cgilua/cgilua.lua $(1)/$(LUA_MODULE_PATH)/cgilua.lua
+	$(INSTALL_DATA) $(PKG_BUILD_DIR)/src/cgilua/authentication.lua $(1)/$(LUA_MODULE_PATH)/cgilua/authentication.lua


Really? the upstream package keeps them in the same dir and needs them in different dirs? Does the upstream package have a makefile with an "install" target you can use?

I'll have to test to make sure the other way works.

karlp · 2017-01-09T10:57:37Z

lang/jsonrpc4lua/Makefile

+
+PKG_NAME:=jsonrpc4lua
+PKG_VERSION:=1.0.1
+PKG_RELEASE:=2


no. pkg_release is obviously 1 here.

karlp · 2017-01-09T10:57:49Z

lang/jsonrpc4lua/Makefile

@@ -0,0 +1,49 @@
+#
+# Copyright (C) 2006-2015 OpenWrt.org


definitely not 2006! (or 2015!)

karlp · 2017-01-09T10:58:33Z

lang/jsonrpc4lua/Makefile

+endef
+
+define Package/jsonrpc4lua/description
+	JSONRPC for Lua


Great description! Is this for clients? for servers? for generating stubs only? Who knows!

karlp · 2017-01-09T11:03:01Z

lang/lua-bit32/Makefile

+LUA_MODULE_PATH:=/usr/lib/lua
+
+define Build/Compile
+	$(TARGET_CROSS)gcc $(TARGET_CFLAGS) $(TARGET_LDFLAGS) -I $(PKG_BUILD_DIR)/c-api/ -o $(PKG_BUILD_DIR)/bit32.so $(PKG_BUILD_DIR)/lbitlib.c


Is upstream really that broken that you have to compile it yourself? Have you considered just using lua-bitop? it's already packaged.

If I recall, at the time bit32 looked better and more future proof. I didn't realize there were other ways to compile it. I'll have to check if I can rework it.

karlp · 2017-01-09T11:04:31Z

lang/lua-inifile/Makefile

+PKG_SOURCE_VERSION:=master
+
+PKG_MAINTAINER:=Alex R <alex@totalwebservices.net>
+PKG_LICENSE=Simplified BSD license


https://spdx.org/licenses/ I think you want "BSD-2-Clause" here

karlp · 2017-01-09T11:05:17Z

lang/luaproc/Makefile

+
+PKG_NAME:=luaproc
+PKG_VERSION:=1.0
+PKG_RELEASE:=4


no, should be 1

karlp · 2017-01-09T11:06:24Z

You've used different names and emails for some of these packages, was that intentional? Are you really sure that none of the existing packages met your needs for any of these?

maxguru · 2017-01-10T01:47:09Z

Regarding different names/emails, I was still in the process of separating identities.

Regarding possible duplication of functionality, I don't believe that's a valid concern.

jsonrpc4lua: The original json4lua package was only semi-functional. The JSON-RPC server component didn't work at all. Initially, I was trying to fix it (see craigmj/json4lua#13) but then, I realized it was trying to do too much. JSON-RPC features should not be bundled into JSON encoding/decoding library. The new fork uses lua-cjson for encoding/decoding and has actually functioning JSON-RPC client and server code.

bit32: I was surprised this wasn't already in the repository, given the version of Lua that was used. "bit32 is the native Lua 5.2 bit manipulation library, backported to Lua 5.1"

alt-getopt: I found this package useful, but it can be left out.
inifile: I found this package useful, but it can be left out.

cgilua: I was also surprised that the repository is missing this package, given that it has lua-wsapi and lua-xavante. Also, I believe this is a dependency for the server component of jsonrpc4lua (and the non-functioning JSON-RPC server code in json4lua).

maxguru · 2017-01-10T03:40:07Z

I forgot to talk about luaproc. It is an excellent library. Very good alternative to Lua Lanes.

karlp · 2017-01-10T11:39:04Z

You'll want to squish the fixup commits at some point too btw.

champtar

Hi @maxguru
you are missing signed off by on all you commits

maxguru · 2017-07-18T01:49:31Z

Rant:

Here is the problem. I was working on the project that triggered the commits prior to June of 2016. I created the pull request because I thought my packages were useful. Nobody responded to my pull request back then. Then after all these months somebody decided to respond finally. I already moved on and no longer have the environment set up. Once I get back to the project, I will see about fixing the couple of issues that I still have left to fix. If somebody else is up for it before then, feel free to do it.

@champtar, I wasn't aware that I needed to sign off commits. I would need to recreate the pull request to fix this, no? I might as well create individual pull requests for each package if that is the case.

diizzyy · 2018-12-30T11:40:56Z

@karlp @thess @hnyman
Close due to submitter timeout?

maxguru · 2018-12-30T23:27:14Z

Unfortunately, I haven't had the time to do what was requested. If somebody wants to take this on, that would be great.

thess · 2018-12-31T01:39:14Z

Way to old - closing.

maxguru added 5 commits June 13, 2016 19:32

Added jsonrpc4lua

1e64410

Added Lua bit32 package

6742457

Added Lua alt-getopt package

a16f78a

Added Lua inifile package

7091ea8

Added Lua cgilua package

2d91509

karlp reviewed Jun 30, 2016
View reviewed changes

maxguru and others added 2 commits August 19, 2016 18:27

Removed unneeded configure blocks

9089ac1

Added Lua luaproc package

8c8d3f5

karlp reviewed Jan 9, 2017

View reviewed changes

diizzyy reviewed Jan 9, 2017

View reviewed changes

karlp reviewed Jan 9, 2017

View reviewed changes

lang/jsonrpc4lua/Makefile Outdated

PKG_NAME:=jsonrpc4lua

PKG_VERSION:=1.0.1

PKG_RELEASE:=2

Copy link

Contributor

karlp Jan 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no. pkg_release is obviously 1 here.

karlp reviewed Jan 9, 2017

View reviewed changes

lang/jsonrpc4lua/Makefile Outdated

@@ -0,0 +1,49 @@

#

# Copyright (C) 2006-2015 OpenWrt.org

Copy link

Contributor

karlp Jan 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely not 2006! (or 2015!)

karlp reviewed Jan 9, 2017

View reviewed changes

lang/luaproc/Makefile Outdated

PKG_NAME:=luaproc

PKG_VERSION:=1.0

PKG_RELEASE:=4

Copy link

Contributor

karlp Jan 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, should be 1

maxguru added 5 commits January 9, 2017 19:52

Fixed copyright notice as requested by @karlp

56c4d67

Fixed PKG_RELEASE

f324c70

Fixed license

f042a62

Fixed description

905a2d7

Updated email address

b242ef8

champtar requested changes Jul 15, 2017

View reviewed changes

champtar added the Add package label Jul 15, 2017

champtar closed this Aug 18, 2017

champtar reopened this Aug 18, 2017

thess closed this Dec 31, 2018

A selection of new Lua packages #2855

A selection of new Lua packages #2855

Uh oh!

Conversation

maxguru commented Jun 14, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

diizzyy commented Jan 7, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

diizzyy Jan 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

karlp commented Jan 9, 2017

Uh oh!

maxguru commented Jan 10, 2017

Uh oh!

maxguru commented Jan 10, 2017

Uh oh!

karlp commented Jan 10, 2017

Uh oh!

champtar left a comment

Choose a reason for hiding this comment

Uh oh!

maxguru commented Jul 18, 2017

Uh oh!

diizzyy commented Dec 30, 2018

Uh oh!

maxguru commented Dec 30, 2018

Uh oh!

thess commented Dec 31, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

diizzyy Jan 10, 2017 •

edited

Loading