Skip to content

usteer: fix memory leak / bad condition #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mu-b wants to merge 2 commits into
base: master
Choose a base branch
from
Open

usteer: fix memory leak / bad condition #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b693db1
Fix logic in load comparison for node selection
mu-b Mar 31, 2026
d729d8c
Handle NULL sta_addr by freeing query memory
mu-b Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion local_node.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,10 @@ usteer_handle_bss_tm_query(struct usteer_local_node *ln, struct blob_attr *msg)
query->dialog_token = blobmsg_get_u8(tb[BSS_TM_QUERY_DIALOG_TOKEN]);

sta_addr = (uint8_t *) ether_aton(blobmsg_get_string(tb[BSS_TM_QUERY_ADDRESS]));
if (!sta_addr)
if (!sta_addr) {
free(query);
return 0;
}

memcpy(query->sta_addr, sta_addr, 6);

Expand Down
2 changes: 1 addition & 1 deletion policy.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ is_better_candidate(struct sta_info *si_cur, struct sta_info *si_new)
reasons |= (1 << UEV_SELECT_REASON_SIGNAL);

if (has_better_load(current_node, new_node) &&
!has_better_load(current_node, new_node))
!has_better_load(new_node, current_node))
reasons |= (1 << UEV_SELECT_REASON_LOAD);

return reasons;
Expand Down