Add.generic.msg.sink #797
Open
Add.generic.msg.sink #797
+568
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewpmartinez
commented
Sep 2, 2025
plorenz
reviewed
Sep 2, 2025
plorenz
reviewed
Sep 2, 2025
plorenz
reviewed
Sep 2, 2025
There was a problem hiding this comment.
Overall, looks good. I don't think we need to bump the version, since these are structures that are not exposed in the Context/edge.Conn api.
To address:
- Question about making the data fields atomic
- There's some compile failures in the tests.
- This needs to be rebased on main, 1.2.3 has already been released and this is showing the EnableHA PR changes as well.
- rename MsgMux to ConnMux, as it muxes Conns - rename sinkId to connId, as that is the language of Conn's - add doc - add generic meta data for MsgSink - remove jwt refreshing client test program
andrewpmartinez
force-pushed
the
add.generic.msg.sink
branch
from
9db2daf to
eb34fd6
Compare
andrewpmartinez
force-pushed
the
add.generic.msg.sink
branch
from
9ca871f to
157bfb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should this have a major version bump?