Standalone SNAPHU unwrapping#2
Open
vbrancat wants to merge 3 commits intoopera-adt:mainfrom
Open
Conversation
|
@vbrancat There is a new public release on isce3 version 0.5 (https://github.com/isce-framework/isce3/tree/v0.5.0). Could we use that for this script? |
Author
|
@yunjunz yes, that is the version of ISCE3 containing the SNAPHU Unwrapper. |
Contributor
|
@vbrancat thanks for adding this stand-alone script. Would you please add the schema and example yaml so that we can test it? |
hfattahi
reviewed
Mar 8, 2022
| import os | ||
| import isce3 | ||
| import isce3.unwrap.snaphu as snaphu | ||
| from nisar.workflows.runconfig import RunConfig |
Contributor
There was a problem hiding this comment.
I don't see this used here.
hfattahi
reviewed
Mar 8, 2022
hfattahi
reviewed
Mar 8, 2022
Author
|
snaphu_schema.txt Schema and default are attached here. |
Author
|
I realized that I was not checking the schema so I have introduce a step to load the runconfig and validate it against the schema. I also updated the code to include the selection of the initialization method since MCF has been now merged in ISCE3 :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a script to run SNAPHU unwrapping as a standalone module within ISCE3. The script can be used with the current version of the
developbranch.The script can be run as:
python unwrap_snaphu.py -r path2YAMLrunconfigThe runconfig can be built using options being exposed here: https://github-fn.jpl.nasa.gov/vbrancat/isce/blob/snaphu_insar_work_branch/share/nisar/schemas/snaphu.yaml
An example of a runconfig file as well as a copy of the schema can be included in this PR.
It is the user responsibility to assign
nlooks(effective number of looks) to properly run SNAPHU. The script provides functionalities to computenlooksbased on basic info but cannot compute it automatically