Skip to content

Standalone SNAPHU unwrapping#2

Open
vbrancat wants to merge 3 commits intoopera-adt:mainfrom
vbrancat:snaphu_standalone
Open

Standalone SNAPHU unwrapping#2
vbrancat wants to merge 3 commits intoopera-adt:mainfrom
vbrancat:snaphu_standalone

Conversation

@vbrancat
Copy link
Copy Markdown

@vbrancat vbrancat commented Mar 3, 2022

This PR introduces a script to run SNAPHU unwrapping as a standalone module within ISCE3. The script can be used with the current version of the develop branch.

The script can be run as:
python unwrap_snaphu.py -r path2YAMLrunconfig

The runconfig can be built using options being exposed here: https://github-fn.jpl.nasa.gov/vbrancat/isce/blob/snaphu_insar_work_branch/share/nisar/schemas/snaphu.yaml
An example of a runconfig file as well as a copy of the schema can be included in this PR.

It is the user responsibility to assign nlooks (effective number of looks) to properly run SNAPHU. The script provides functionalities to compute nlooks based on basic info but cannot compute it automatically

@yunjunz
Copy link
Copy Markdown

yunjunz commented Mar 7, 2022

@vbrancat There is a new public release on isce3 version 0.5 (https://github.com/isce-framework/isce3/tree/v0.5.0). Could we use that for this script?

@vbrancat
Copy link
Copy Markdown
Author

vbrancat commented Mar 7, 2022

@yunjunz yes, that is the version of ISCE3 containing the SNAPHU Unwrapper.

@hfattahi
Copy link
Copy Markdown
Contributor

hfattahi commented Mar 8, 2022

@vbrancat thanks for adding this stand-alone script. Would you please add the schema and example yaml so that we can test it?

Comment thread bin/unwrap_snaphu.py Outdated
import os
import isce3
import isce3.unwrap.snaphu as snaphu
from nisar.workflows.runconfig import RunConfig
Copy link
Copy Markdown
Contributor

@hfattahi hfattahi Mar 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this used here.

Comment thread bin/unwrap_snaphu.py Outdated
Comment thread bin/unwrap_snaphu.py Outdated
@vbrancat
Copy link
Copy Markdown
Author

vbrancat commented Mar 8, 2022

snaphu_schema.txt
snaphu_default.txt

Schema and default are attached here.

@hfattahi hfattahi requested a review from taliboliver March 15, 2022 17:01
@vbrancat
Copy link
Copy Markdown
Author

I realized that I was not checking the schema so I have introduce a step to load the runconfig and validate it against the schema. I also updated the code to include the selection of the initialization method since MCF has been now merged in ISCE3 :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants