Merged
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
src/argo-archive-list.ts
Outdated
Comment on lines
+166
to
+168
| ${pages | ||
| .sort((a, b) => Number(b.ts) - Number(a.ts)) | ||
| .map((page) => { |
There was a problem hiding this comment.
Suggestion: Add a null check before sorting the pages array to prevent potential runtime errors if pages is null or undefined. [possible issue, importance: 7]
Suggested change
| ${pages | |
| .sort((a, b) => Number(b.ts) - Number(a.ts)) | |
| .map((page) => { | |
| ${(pages || []) | |
| .sort((a, b) => Number(b.ts) - Number(a.ts)) | |
| .map((page) => { |
yamijuan
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
In this PR, I added sorting archives by date within the date buckets, with the most recent ones appearing at the top.
PR Type
Enhancement
Description
Sort archives by date within date buckets
Most recent archives appear at top
Changes walkthrough 📝
argo-archive-list.ts
Add chronological sorting within date bucketssrc/argo-archive-list.ts