✨ Deprecate spec.ServiceAccount and remove synthetic permissions feature #2242
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
trgeiger
force-pushed
the
remove-sa
branch
4 times, most recently
from
29af310 to
bc04e3d
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
trgeiger
force-pushed
the
remove-sa
branch
2 times, most recently
from
d2844ab to
dad8dcb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2242 +/- ##
==========================================
- Coverage 72.87% 72.39% -0.48%
==========================================
Files 88 86 -2
Lines 8733 8151 -582
==========================================
- Hits 6364 5901 -463
+ Misses 1955 1869 -86
+ Partials 414 381 -33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| Namespace string `json:"namespace"` | ||
|
|
||
| // serviceAccount is a reference to a ServiceAccount used to perform all interactions | ||
| // Deprecated: ServiceAccount is ignored by OLM and will be removed in a future release. |
There was a problem hiding this comment.
Would it make sense to also log a warning during reconciliation if this field is still set by a user?
| // | ||
| // <opcon:experimental> | ||
| // +optional | ||
| Config *ClusterExtensionConfig `json:"config,omitempty"` |
There was a problem hiding this comment.
Looks like we are adding ClusterExtensionConfig to the spec. While it looks like a good start for supporting inline config, it seems unrelated to the serviceAccount deprecation work (unless I am missing something here).
Just checking - Is it intentional to include this here, or would it make sense to split it into a separate PR?
There was a problem hiding this comment.
I have re-based and just re-based again so I'm not sure why this is here... must be user error by me during some rebase reconciliation the other day. I'll remove this
Make spec.ServiceAccount an optional field and note that it's now deprecated and does not perform any function. Make OLM use cluster-admin by default for managing ClusterExtensions. Remove the permissions preflight experimental feature flag. Remove the synthetic permissions experimental feature flag.
3 participants
Make spec.ServiceAccount an optional field and note that it's now deprecated and does not perform any function. Make OLM use cluster-admin by default for managing ClusterExtensions.
Remove the synthetic permissions experimental feature flag.
Description
Reviewer Checklist