🌱 Update inline config docs and annotations

[perdasilva]

Description

Addresses enhancement PR reviewer comments by:

• Updates inline configuration documentation
• Adds missing // +unionMember annotation to Inline
• Adds // +kubebuilder:validation:MinProperties=1 validation to Inline to ensure empty configurations {} cannot be specified
• Adds additional admission unit test inc. to test the added validation annotation

Reviewer Checklist

• API Go Documentation
• Tests: Unit Tests (and E2E Tests, if appropriate)
• Comprehensive Commit Messages
• Links to related GitHub Issue(s)

[netlify]

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	6b65cca
🔍 Latest deploy log	https://app.netlify.com/projects/olmv1/deploys/692ef2b84e13370008e88851
😎 Deploy Preview	https://deploy-preview-2366--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[Copilot]

Pull request overview

This PR improves the inline configuration documentation and adds the +unionMember annotation to the ClusterExtensionConfig.Inline field as suggested by an API review. The changes make the documentation clearer, fix a grammatical error in the original text, and ensure proper union type annotation for the Kubernetes API.

Key Changes:

• Rewrote inline configuration documentation for better clarity and grammar
• Added // +unionMember annotation to the Inline field in ClusterExtensionConfig
• Updated all generated CRD manifests and API documentation to reflect the source changes

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
api/v1/clusterextension_types.go	Updated inline configuration documentation comments and added +unionMember annotation
manifests/experimental.yaml	Generated CRD manifest updated with new documentation text
manifests/experimental-e2e.yaml	Generated E2E CRD manifest updated with new documentation text
helm/olmv1/base/operator-controller/crd/experimental/olm.operatorframework.io_clusterextensions.yaml	Helm CRD manifest updated with new documentation text
docs/api-reference/olmv1-api-reference.md	API reference documentation updated to match source code comments

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.51%. Comparing base (34394ce) to head (6b65cca).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2366      +/-   ##
==========================================
+ Coverage   70.61%   74.51%   +3.90%     
==========================================
  Files          93       93              
  Lines        7333     7333              
==========================================
+ Hits         5178     5464     +286     
+ Misses       1720     1435     -285     
+ Partials      435      434       -1     

Flag	Coverage Δ
e2e	44.47% <ø> (-0.07%)	⬇️
experimental-e2e	48.78% <ø> (+34.83%)	⬆️
unit	58.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[tmshort]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• api/OWNERS [tmshort]
• docs/OWNERS [tmshort]
• helm/OWNERS [tmshort]
• internal/operator-controller/OWNERS [tmshort]
• manifests/OWNERS [tmshort]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[pedjak]

Adding this did not produce any change on CRD, should it?

[perdasilva]

Great call out! I went poking about and here's what I found out (with the help of Gemini):

Annotation	Effect on CRD Schema	Notes
// +union	None (Visible)	Treated as documentation only.
// +unionMember	None	Fields remain standard optional pointers.
// +unionDiscriminator	None (usually)	Does not automatically generate an Enum or validation.

This means that the CEL expressions must be manually created to enforce

While controller-gen generates no visible effect, in client-gen they seem to be used.

If you are generating a full-blown Kubernetes Clientset (using k8s.io/code-generator rather than just controller-runtime), these annotations become functional.

Specifically, they affect the generation of ApplyConfigurations.

    When using Server-Side Apply (SSA) in Go code, the generated ApplyConfiguration structs need to know if a field is a union.

    If tagged correctly, the generated Go client code for "applying" the object will know to clear the other fields in the union when you set a new one.

It also suggests to keep them for other developers to make the intent clear to other developers (not a huge argument for me since it's pretty clear anyway, but ok...)