-
Notifications
You must be signed in to change notification settings - Fork 47
Implementation of bokeh backend.
#652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
timmens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
| from bokeh.layouts import gridplot | ||
| from bokeh.plotting import figure | ||
|
|
||
| plots: list[list[Any]] = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have more type information than Any?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review!
Do we have more type information than Any?
Ideally the type hint should be list[list[figure]]. However there is something unexpected going on with both of the mypy stubtests (the independent job and the pre-commit job).
When using list[list[figure]] the independent job fails although the pre-commit job passes, with
error: No overload variant of "gridplot" matches argument types "list[list[figure]]", "int | None", "int | None", "str" [call-overload]Ignoring the error with a # type: ignore[call-overload] causes the pre-commit job to complain about the unused ignore statement. Unfortunately, I am not able to find a type hint (other than list[list[Any]]) that lets both these tests pass.
Summary of Changes
line_plotandgrid_line_plotfunction for bokeh.Plot Comparision
Checklist