Jordan/fix group by getter #185
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mizely/nuclear-js into yun/grouping-observers-by-getters
… still handler for the getter, do not remove the reference in store.
|
@jordangarcia looks like you've missed the commit 77ced5e about the new test case in this PR. |
|
@jordangarcia I see. The code is good to go for me. |
|
LGTM too. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lyonlai I checked out your branch and noticed a couple of test failures for some observer unwatch edge cases. I've added two new tests in master for these test cases and updated your branch to address these.
Mind giving this a PR before I merge?
#183