-
Notifications
You must be signed in to change notification settings - Fork 4
[FSSDK-11875] chore: add support for android 15 #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Bump compile SDK version to 35 and build tools version to "35.0.0" - Update target SDK version to 35 - Add namespace 'com.optimizely.optimizely_flutter_sdk' - Enable buildConfig feature - Update kotlin-stdlib-jdk7 to version 2.1.0 - Update jackson-databind to version 2.17.2 - Set minSdkVersion and targetSdkVersion to 35 for example app - Update distributionUrl in gradle-wrapper.properties to Gradle 8.10.2 - Update android plugin version to 8.7.0 and kotlin-android version to 2.1.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Let's test with different version numbers in app.
- Update compile SDK version to 36 and build tools version to "36.0.0" - Change min SDK version to 21 and target SDK version to 36 in the Android build configuration - Update compile SDK version to 36 and target SDK version to 36 in the example app build.gradle file
- Update compile_sdk_version and build_tools_version to 35 - Remove target_sdk_version from ext - Update compileSdkVersion and targetSdkVersion in app/build.gradle to 35
- Update compile SDK version to use project property if available, fallback to default - Update target SDK version to use project property if available, fallback to default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. A couple of clean ups in example apps
…dkVersion - Simplify specifying compileSdkVersion and targetSdkVersion directly from flutter configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Update target SDK version to 35
Update distributionUrl in gradle-wrapper.properties to Gradle 8.10.2
Update android plugin version to 8.7.0 and kotlin-android version to 2.1.0
New requirement by google https://developer.android.com/google/play/requirements/target-sdk
Test plan
Issues