[FSSDK-11578] Ruby: Update impression event handling and send notification for global holdout #376
Conversation
…ation for global holdout
…esra/FSSDK-11578_impression_and_notification
There was a problem hiding this comment.
This pull request introduces improvements to how holdouts are handled for feature flags in the Optimizely codebase. The changes focus on ensuring that only active holdouts are considered, updating the logic to use flag IDs instead of keys, and improving the robustness of variation selection for holdouts. Additionally, new test data for holdouts has been added to the spec parameters. LGTM
| end | ||
|
|
||
| def get_holdouts_for_flag(flag_key) | ||
| def get_holdouts_for_flag(flag_id) |
There was a problem hiding this comment.
HAven't done event handling yet for holdouts myself, but I wonder here, it could be a potential bug if flag_key is used accidentally instead of flag_id in this PR. Are there any checks needed to make sure we use flag_id?
I'm not 100% sure, just pointing to this in case a check is needed. Does swift sdk has any additional guards maybe etc
There was a problem hiding this comment.
We can a comment for better clarification. For Swift flag_id is none optional, so there is no way to pass null value.
| end | ||
|
|
||
| def get_holdouts_for_flag(flag_key) | ||
| def get_holdouts_for_flag(flag_id) |
There was a problem hiding this comment.
We can a comment for better clarification. For Swift flag_id is none optional, so there is no way to pass null value.
esrakartalOpt
deleted the
esra/FSSDK-11578_impression_and_notification
branch
5 participants
Summary
Test plan
PR checks
Issues