[WIP] Use custom model name in deployment #1236
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrimk
requested review from
darenr,
mayoor,
mrDzurb,
VipulMascarenhas,
qiuosier and
ahosler
as code owners
oracle-contributor-agreement
bot
added
the
OCA Verified
agrimk
changed the title
|
📌 Cov diff with main: 📌 Overall coverage: |
mrDzurb
reviewed
Jul 30, 2025
ads/aqua/model/model.py
Outdated
| @@ -147,6 +147,7 @@ class AquaModelApp(AquaApp): | |||
| def create( | |||
| self, | |||
| model_id: Union[str, AquaMultiModelRef], | |||
| display_name: Optional[str] = None, | |||
There was a problem hiding this comment.
It can be risky to insert attributes in the middle of an existing list, as it may lead to unintended side effects or compatibility issues. A better practice is to append new attributes at the end of the list .
|
📌 Cov diff with main: 📌 Overall coverage: |
…le/accelerated-data-science into use_custom_model_name_in_deployment
|
📌 Cov diff with main: 📌 Overall coverage: |
mrDzurb
reviewed
Aug 15, 2025
| @@ -204,6 +207,9 @@ def create( | |||
| **(defined_tags or {}), | |||
| } | |||
|
|
|||
| if display_name: | |||
There was a problem hiding this comment.
I’m not sure I understand the logic here. I thought we wanted to introduce the model name that would be used for inferencing, but here we’re changing the display name of the MC record.
Could you add more description in the PR explaining what this PR for?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description