adaptivemm: initial vm.vfs_cache_pressure tuning algorithm #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Member
drakenclimber
left a comment
drakenclimber
left a comment
There was a problem hiding this comment.
The logic looks solid to me. I had a few minor comments but no showstoppers.
sidkumar99
force-pushed
the
vfs_cache_pressure_tuning
branch
from
056d6ac to
418a8a3
Compare
Member
Author
|
I think I've addressed all your comments from the first review |
sidkumar99
force-pushed
the
vfs_cache_pressure_tuning
branch
from
418a8a3 to
1d65f3e
Compare
Implement a simple vm.vfs_cache_pressure tuning algorithm. The algorithm works by using a user supplied hint which is the PREFER_OBJECT_CACHING option in the configuration file. This hint indicates if the user would rather have their system preserve dentry and inode object caches at the cost of higher memory utilizaiton. Some workloads are strongly impacted by the level on dentry and inode caching so it may benefit these workloads to have the mm system deprioritize reclaiming these caches. If this option is selected, the inode and dentry numbers are monitored and if they are projected to increase (via the slope of a best line fit), the sysctl is lowered by 10% and if they are projected to decrease, the sysctl is increased by 10%. The opposite behavior occurs if PREFER_OBJECT_CACHING is specified to 0. Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
sidkumar99
force-pushed
the
vfs_cache_pressure_tuning
branch
from
1d65f3e to
1a17ed7
Compare
drakenclimber
approved these changes
Apr 23, 2025
Member
drakenclimber
left a comment
drakenclimber
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-by: Tom Hromatka <tom.hromatka@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a simple vm.vfs_cache_pressure tuning algorithm. The algorithm works by using a user supplied hint which is the PREFER_OBJECT_CACHING option in the configuration file. This hint indicates if the user would rather have their system preserve dentry and inode object caches at the cost of higher memory utilizaiton. Some workloads are strongly impacted by the level on dentry and inode caching so it may benefit these workloads to have the mm system deprioritize reclaiming these caches. If this option is selected, the inode and dentry numbers are monitored and if they are projected to increase (via the slope of a best line fit), the sysctl is lowered by 10% and if they are projected to decrease, the sysctl is increased by 10%. The opposite behavior occurs if PREFER_OBJECT_CACHING is specified to 0.