-
Notifications
You must be signed in to change notification settings - Fork 6
Implement Base Topics Functionality #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements comprehensive base topic functionality for the Coherence Go client, adding support for publishers, subscribers, and event lifecycle management. It introduces the foundation for messaging capabilities with proper channel management, lifecycle events, and comprehensive testing.
- Adds core topic APIs including NamedTopic, Publisher, and Subscriber interfaces with lifecycle management
- Implements publishing and subscribing functionality with filtering, transformers, and subscriber groups
- Creates comprehensive test suite covering basic operations, event handling, and various subscriber configurations
Reviewed Changes
Copilot reviewed 64 out of 67 changed files in this pull request and generated 7 comments.
Show a summary per file
File | Description |
---|---|
test/utils/docker-compose-2-members.yaml |
Updates copyright year and adds health check ports for coherence members |
test/e2e/topics/*.go |
Comprehensive test suite for topic functionality including basic operations, events, and subscriber tests |
test/dapr/my-dapr-app/* |
Adds Dapr integration test components and application |
scripts/*.sh |
Updates test scripts with new version numbers and adds topic testing support |
proto/v1/*.pb.go |
Enhances protobuf messages with client member identity and extended queue operations |
java/pom.xml |
Updates Maven repository URLs and adds health check port configuration |
java/coherence-go-test/src/main/resources/test-cache-config.xml |
Adds topic scheme configuration |
java/coherence-go-test/src/main/java/com/oracle/coherence/go/testing/RestServer.java |
Adds REST endpoint for destroying topics |
coherence/*.go |
Core implementation of topic functionality including APIs, events, and client management |
coherence/{topic,subscriber,publisher,subscribergroup}/*.go |
Package-specific implementations for topic components |
Comments suppressed due to low confidence (3)
coherence/v1client.go:163
- There appears to be an extra closing brace on line 167. The conditional block starting at line 164 should end after line 166, but there's an additional closing brace that creates unbalanced braces.
if response == nil {
coherence/topics.go:90
- Function name has a typo: 'CreatSubscriberWithTransformer' should be 'CreateSubscriberWithTransformer' (missing 'e').
GetChannelCount() int32
coherence/v1client.go:523
- The commented line '// cache' appears to be leftover from refactoring and should be removed as it adds no value and could be confusing.
isTopic = true
|
No description provided.