[GR-68862] Github: [Native Image] [Windows] Required environment variable names use case-sensitive compare on Windows #11819
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
stooke
changed the title
1 task
adinn
approved these changes
Jul 30, 2025
adinn
requested review from
chumer and
alexander-schubert
and removed request for
alexander-schubert
|
@chumer , do you have bandwidth to take a look at this simple fix, or should we ask someone else? |
zakkak
approved these changes
Aug 19, 2025
|
@olpaw @zapster This is breaking our JDK 26-based Mandrel CI on Windows. Could you please help get this reviewed and integrated? |
|
thanks, I'll take care. |
zapster
changed the title
zapster
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple fix for #11818 (Required environment variable names use case-sensitive compare on Windows).
The call to mapKey() is inlined into the call to isKeyRequiredCondition().
Currently this particular call to mapKey() has no effect.