Skip to content

Conversation

@loicottet
Copy link
Member

What does this PR do?

Adds missing registrations to the liquibase metadata, made necessary by the switch to complete reflection types. This new metadata is necessary because ColumnConfig.getSerializableFields() and AddColumnConfig.getSerializableFields() currently return empty arrays, which is incorrect behavior. This is due to ReflectionSerializer.getFields performing a call to Class.getDeclaredMethods() in the background.

oracle/graal#12521 fixes Native Image behavior by returning a correct list of fields in this situation for types registered for reflection. Fields returned by getSerializableFields() are then used to access the field values, and should therefore be registered for reflective access.

Code sections where the PR accesses files, network, docker or some external service

none

Checklist before merging

@vjovanov vjovanov self-requested a review November 14, 2025 19:42
@vjovanov
Copy link
Member

Why doesn't the agent figure that out in the tests?

@loicottet
Copy link
Member Author

loicottet commented Nov 17, 2025

The tests that fail because of this issue (https://github.com/oracle/graal/actions/runs/19335605323) don't have an agent run. I believe an agent run would solve these issues.

@vjovanov vjovanov merged commit 58a9876 into oracle:master Nov 17, 2025
259 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants