Skip to content

chore: fix heuristic dependency handling temporarily #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025
Merged

chore: fix heuristic dependency handling temporarily #1144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/macaron/slsa_analyzer/checks/detect_malicious_metadata_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,14 @@ def _should_skip(
Returns True if any result of the dependency heuristic does not match the expected result.
Otherwise, returns False.
"""
mapped_h: dict[Heuristics, list[HeuristicResult]] = {}
for heuristic, expected_result in depends_on:
dep_heuristic_result: HeuristicResult = results[heuristic]
if dep_heuristic_result is not expected_result:
return True
mapped_h.setdefault(heuristic, []).append(expected_result)

for heuristic, exp_results in mapped_h.items():
dep_heuristic_result = results.get(heuristic)
if dep_heuristic_result not in exp_results:
return True
return False

def analyze_source(
Expand Down
Loading