feature/pretty-MultiLabelConfusionMatrix-toString#136
Conversation
| } | ||
| sb.append("]"); | ||
| return sb.toString(); | ||
| return getDomain().getDomain().stream() |
There was a problem hiding this comment.
This is sensitive to the iteration order of the HashSet inside the domain, whereas the old one was fixed on construction (though when it was constructed it was fixed based on the iteration order of the HashSet in the domain).
This comment is more a todo for later when the label domains have consistent iteration order (probably lexicographic like the features).
There was a problem hiding this comment.
Ah, good point. That variable iteration order has confused me several times. There's always LinkedHashSet? Or maybe https://docs.oracle.com/javase/9/docs/api/java/util/Set.html#of-E...- would have stable iteration order like Guava's ImmutableHashSet? How long will Java 8 be required?
|
I'm trying to figure out why the CI hasn't run, once I've sorted that out and it passes I'll merge in this PR. |
|
Seems like the recent change to GH Actions which limits PR workflow runs from new contributors is causing trouble. I've ran the CI tests locally and everything passes, so I'm going to merge this now. |
Description
Easier to read
MultiLabelConfusionMatrix.toString(). (Subset of PR [#128] which includes other work.)Motivation
Such a feature would make analysis of
MultiLabelmodels simpler: in particularMultiLabelConfusionMatrixtoString()is hard to interpret. Compareto
cc @Craigacp