Skip to content

Fix ticket #96 add Extent to CRS#126

Open
mukoki wants to merge 1 commit intoorbisgis:masterfrom
mukoki:add_extent_to_crs
Open

Fix ticket #96 add Extent to CRS#126
mukoki wants to merge 1 commit intoorbisgis:masterfrom
mukoki:add_extent_to_crs

Conversation

@mukoki
Copy link
Contributor

@mukoki mukoki commented Dec 28, 2019

Proposition to add extent to CRS.
As Extent is an interface, I just implemented it in CoordinateReferenceSystem. Default implementation always return true. GeodeticCRS implementation makes it possible to define Extent from projected coordinates or from geographic coordinates (referring to this CRS's Datum). In the later case, geographic coordinates are transformed into this CRS's coordinates.
Needs more tests.

@ebocher
Copy link
Member

ebocher commented Jan 7, 2021

Dear @mukoki
We plan to release a new version of CTS. Should this PR be included in the next release?
Cheers

@mukoki
Copy link
Contributor Author

mukoki commented Jan 7, 2021

Quite old one... should still be OK. It would probably need more tests though. I think that merging it just before a release does not make much sense as it is not sufficient to solve concrete problems. I would recommand to merge it, test it, try to add new capabilities using the new methods then release.

@ebocher
Copy link
Member

ebocher commented Jan 8, 2021

Thanks I'll add it to the 1.7 road map

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants