Skip to content

Lint and format#29

Open
Benjamintdk wants to merge 152 commits intoorcasound:masterfrom
Benjamintdk:lint-and-format
Open

Lint and format#29
Benjamintdk wants to merge 152 commits intoorcasound:masterfrom
Benjamintdk:lint-and-format

Conversation

@Benjamintdk
Copy link
Copy Markdown
Collaborator

@Benjamintdk Benjamintdk commented Jun 19, 2022

Resolves #16. Builds on #23 #24 #26 #27 #28. Applies linting and formatting based on a pre-commit configuration. Credit to @Molkree for providing the base config template from the Orca Action Workflow project.

Major changes:

  • Incorporation of setup.cfg to specify configurations, and a pre-commit yaml file to specify which tools to run.
  • Added eslint on top of the existing python utilities to format the javascript and typescript code
  • Any changes to other files as a result of linting and formatting
  • Added GH Action for linting and formatting

Minor changes:

  • Moved .eslintrc.json file out of the webapp folder in order to be accessed by pre-commit for linting configurations
  • Refactored the testing and linting+formatting into a single GH Action, to be run whenever new commits are pushed to a remote/PR.

Benjamintdk and others added 30 commits March 27, 2022 11:32
…environment, and changed webpack config for webapp docker deployment
Trying docker dev first to see if there are any issues with networking or starting containers
Removed verbose flag
Removing health check and dependency to hopefully get more logs
Trying to add in region to solve the issue
@Benjamintdk Benjamintdk marked this pull request as ready for review August 17, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set up formatting + linting for both python and node with precommit.ci tool

1 participant