Open
Conversation
kantera800
reviewed
Jul 22, 2020
kantera800
reviewed
Jul 22, 2020
kantera800
reviewed
Jul 22, 2020
kantera800
reviewed
Jul 22, 2020
kantera800
reviewed
Jul 22, 2020
| } | ||
|
|
||
| // If the socket is not valid, attempt to re-establish the connection | ||
| if (!m_sockMaster) { |
There was a problem hiding this comment.
camel case is not according to prplmesh coding style .
I know that you see a lot of similar cases in the code right now , but we try not to introduce any more code taht is not according to the coding style . also from time to time we all try to fix it a bit .
kantera800
reviewed
Jul 22, 2020
|
In general the changes are ok there are some small coding style changes required and a few nitpicks.
|
Signed-off-by: Oren Vormaser <orenvorm@gmail.com>
Signed-off-by: Oren Vormaser <orenvorm@gmail.com>
8a57a49 to
4339113
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR serves as demo for the use of CLI commands and BML messages.
This PR includes:
This ACTION_BML_OREN_REVERSE_STR_REQUEST contain a string that will be reversed and return to the user by ACTION_BML_OREN_REVERSE_STR_RESPONSE.