Skip to content

Demonstration of CLI and BML message flows#1

Open
orenvor wants to merge 2 commits intomasterfrom
dev/orenvor/new_bml_msg
Open

Demonstration of CLI and BML message flows#1
orenvor wants to merge 2 commits intomasterfrom
dev/orenvor/new_bml_msg

Conversation

@orenvor
Copy link
Owner

@orenvor orenvor commented Jul 22, 2020

This PR serves as demo for the use of CLI commands and BML messages.

This PR includes:

  • Add CLI command: OREN_PRINT which demonstrate CLI based flow. This cli print a given string to log.
  • Add BML message: OREN_REVERSE_STR which demonstrate request-response based flow of BML massages.
    This ACTION_BML_OREN_REVERSE_STR_REQUEST contain a string that will be reversed and return to the user by ACTION_BML_OREN_REVERSE_STR_RESPONSE.

@orenvor orenvor changed the title Dev/orenvor/new bml msg Demonstration of CLI and BML message flows Jul 22, 2020
@orenvor orenvor self-assigned this Jul 22, 2020
}

// If the socket is not valid, attempt to re-establish the connection
if (!m_sockMaster) {
Copy link

@kantera800 kantera800 Jul 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

camel case is not according to prplmesh coding style .
I know that you see a lot of similar cases in the code right now , but we try not to introduce any more code taht is not according to the coding style . also from time to time we all try to fix it a bit .

@kantera800
Copy link

kantera800 commented Jul 22, 2020

In general the changes are ok there are some small coding style changes required and a few nitpicks.
But these changes doesn't complete the task they were meant to do ,
the definition of the task was to:

  1. get parameter from cli
  2. send CMDU from controller to agent
  3. print parameter in agent logs.
    This PR never actually sends anything to the agent ,
    instead internal bml CMDU request parsed in son_master (controller) and then returned back to the awaiting bml process using the promise mechanism.

orenvor added 2 commits July 23, 2020 16:01
Signed-off-by: Oren Vormaser <orenvorm@gmail.com>
Signed-off-by: Oren Vormaser <orenvorm@gmail.com>
@orenvor orenvor force-pushed the dev/orenvor/new_bml_msg branch from 8a57a49 to 4339113 Compare July 23, 2020 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants