feat: merge date and zerotime into single field#292
Merged
martinkrivda merged 4 commits intomainfrom Apr 28, 2026
Merged
Conversation
…h, also removes ambiguity of the date field, which when converted to local date-time might end up in the day before, #165
Contributor
Author
|
Unify date of the event in the Event Information card and date on the Event Link card, the format is slightly different - #165 . It looks that the first one respects system setup and the second one is static/fixed. |
martinkrivda
requested changes
Apr 27, 2026
| @@ -0,0 +1,7 @@ | |||
| -- Merge separate date (DATE) and zeroTime (TIME) columns into a single DATETIME column. | |||
| -- The new `date` stores the UTC event start timestamp. | |||
| ALTER TABLE `event` ADD COLUMN `date_tmp` DATETIME(3) NOT NULL DEFAULT '1970-01-01 00:00:00.000'; | |||
Collaborator
There was a problem hiding this comment.
Do we need to record the event time in milliseconds with three decimal places of precision? Since the event will likely always start on the minute, I believe DATETIME(0) is a more appropriate choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
CLA.mdin therepository root.